svn rev #24642: branches/krb5-1-9/src/lib/krb5/os/

tlyu@MIT.EDU tlyu at MIT.EDU
Fri Feb 18 23:33:48 EST 2011


http://src.mit.edu/fisheye/changelog/krb5/?cs=24642
Commit By: tlyu
Log Message:
ticket: 6867
version_fixed: 1.9.1
status: resolved

pull up r24634 from trunk

 ------------------------------------------------------------------------
 r24634 | ghudson | 2011-02-13 11:12:36 -0800 (Sun, 13 Feb 2011) | 10 lines

 ticket: 6867
 subject: Trace logging file descriptor leak
 target_version: 1.9.1
 tags: pullup

 File descriptors created for trace logging were never being closed.
 With short-lived contexts this leak would eventually overflow the
 process's file table.  Correct this oversight by closing the file
 descriptor in file_trace_cb before freeing its container.


Changed Files:
U   branches/krb5-1-9/src/lib/krb5/os/trace.c
Modified: branches/krb5-1-9/src/lib/krb5/os/trace.c
===================================================================
--- branches/krb5-1-9/src/lib/krb5/os/trace.c	2011-02-18 15:06:57 UTC (rev 24641)
+++ branches/krb5-1-9/src/lib/krb5/os/trace.c	2011-02-19 04:33:48 UTC (rev 24642)
@@ -322,6 +322,7 @@
 
     if (info == NULL) {
         /* Null info means destroy the callback data. */
+        close(*fd);
         free(fd);
         return;
     }




More information about the cvs-krb5 mailing list