svn rev #24634: trunk/src/lib/krb5/os/

ghudson@MIT.EDU ghudson at MIT.EDU
Sun Feb 13 14:12:36 EST 2011


http://src.mit.edu/fisheye/changelog/krb5/?cs=24634
Commit By: ghudson
Log Message:
ticket: 6867
subject: Trace logging file descriptor leak
target_version: 1.9.1
tags: pullup

File descriptors created for trace logging were never being closed.
With short-lived contexts this leak would eventually overflow the
process's file table.  Correct this oversight by closing the file
descriptor in file_trace_cb before freeing its container.



Changed Files:
U   trunk/src/lib/krb5/os/trace.c
Modified: trunk/src/lib/krb5/os/trace.c
===================================================================
--- trunk/src/lib/krb5/os/trace.c	2011-02-13 18:48:06 UTC (rev 24633)
+++ trunk/src/lib/krb5/os/trace.c	2011-02-13 19:12:36 UTC (rev 24634)
@@ -321,6 +321,7 @@
 
     if (info == NULL) {
         /* Null info means destroy the callback data. */
+        close(*fd);
         free(fd);
         return;
     }




More information about the cvs-krb5 mailing list