svn rev #24886: trunk/src/kadmin/server/

[ghudson@MIT.EDU]

http://src.mit.edu/fisheye/changelog/krb5/?cs=24886
Commit By: ghudson
Log Message:
ticket: 6903
subject: Fix memory leak in kpasswd server UDP error path
target_version: 1.9.1
tags: pullup

The dispatch() in kadmind's schpw.c could return a failure code with
an allocated response container.  net-server.c does not expect this
and leaks the container in the UDP case.  Free the container in
dispatch() if we are returning an error.



Changed Files:
U   trunk/src/kadmin/server/schpw.c
Modified: trunk/src/kadmin/server/schpw.c
===================================================================
--- trunk/src/kadmin/server/schpw.c	2011-04-16 18:10:23 UTC (rev 24885)
+++ trunk/src/kadmin/server/schpw.c	2011-04-19 16:37:19 UTC (rev 24886)
@@ -535,6 +535,10 @@
                                remote_faddr,
                                request,
                                *response);
+    if (ret) {
+        krb5_free_data(server_handle->context, *response);
+        *response = NULL;
+    }
 
 cleanup:
     if (local_kaddrs != NULL)