svn rev #24309: trunk/src/lib/krb5/os/

ghudson@MIT.EDU ghudson at MIT.EDU
Wed Sep 15 11:50:15 EDT 2010


http://src.mit.edu/fisheye/changelog/krb5/?cs=24309
Commit By: ghudson
Log Message:
ticket: 6777

In krb5_sname_to_principal, correctly handle failures from
krb5_build_principal.



Changed Files:
U   trunk/src/lib/krb5/os/sn2princ.c
Modified: trunk/src/lib/krb5/os/sn2princ.c
===================================================================
--- trunk/src/lib/krb5/os/sn2princ.c	2010-09-15 15:48:44 UTC (rev 24308)
+++ trunk/src/lib/krb5/os/sn2princ.c	2010-09-15 15:50:15 UTC (rev 24309)
@@ -196,9 +196,9 @@
         retval = krb5_build_principal(context, ret_princ, strlen(realm),
                                       realm, sname, remote_host,
                                       (char *)0);
+        if (retval == 0)
+            krb5_princ_type(context, *ret_princ) = type;
 
-        krb5_princ_type(context, *ret_princ) = type;
-
 #ifdef DEBUG_REFERRALS
         printf("krb5_sname_to_principal returning\n");
         printf("realm: <%s>, sname: <%s>, remote_host: <%s>\n",




More information about the cvs-krb5 mailing list