svn rev #24480: trunk/src/lib/gssapi/krb5/

ghudson@MIT.EDU ghudson at MIT.EDU
Mon Oct 25 15:37:04 EDT 2010


http://src.mit.edu/fisheye/changelog/krb5/?cs=24480
Commit By: ghudson
Log Message:
ticket: 6793
target_version: 1.9
tags: pullup

In acquire_init_cred in the GSS krb5 mech, don't intern cred->name,
since it's not used as an output parameter.  Fixes a memory leak.
Reported by aberry at likewise.com.



Changed Files:
U   trunk/src/lib/gssapi/krb5/acquire_cred.c
Modified: trunk/src/lib/gssapi/krb5/acquire_cred.c
===================================================================
--- trunk/src/lib/gssapi/krb5/acquire_cred.c	2010-10-24 14:39:41 UTC (rev 24479)
+++ trunk/src/lib/gssapi/krb5/acquire_cred.c	2010-10-25 19:37:03 UTC (rev 24480)
@@ -190,8 +190,7 @@
         krb5_kt_free_entry(context, &entry);
 
         assert(cred->name == NULL);
-        code = kg_init_name(context, desired_princ, NULL,
-                            KG_INIT_NAME_INTERN, &cred->name);
+        code = kg_init_name(context, desired_princ, NULL, 0, &cred->name);
         if (code) {
             *minor_status = code;
             return GSS_S_FAILURE;
@@ -384,8 +383,7 @@
      */
     if (cred->name == NULL) {
         if ((code = kg_init_name(context, ccache_princ, NULL,
-                                 KG_INIT_NAME_NO_COPY | KG_INIT_NAME_INTERN,
-                                 &cred->name))) {
+                                 KG_INIT_NAME_NO_COPY, &cred->name))) {
             krb5_free_principal(context, ccache_princ);
             krb5_cc_close(context, ccache);
             *minor_status = code;




More information about the cvs-krb5 mailing list