svn rev #24496: branches/krb5-1-9/src/lib/gssapi/krb5/

tlyu@MIT.EDU tlyu at MIT.EDU
Mon Nov 1 16:36:22 EDT 2010


http://src.mit.edu/fisheye/changelog/krb5/?cs=24496
Commit By: tlyu
Log Message:
ticket: 6793
version_fixed: 1.9
status: resolved

pull up r24480 from trunk

 ------------------------------------------------------------------------
 r24480 | ghudson | 2010-10-25 15:37:03 -0400 (Mon, 25 Oct 2010) | 8 lines

 ticket: 6793
 target_version: 1.9
 tags: pullup

 In acquire_init_cred in the GSS krb5 mech, don't intern cred->name,
 since it's not used as an output parameter.  Fixes a memory leak.
 Reported by aberry at likewise.com.


Changed Files:
U   branches/krb5-1-9/src/lib/gssapi/krb5/acquire_cred.c
Modified: branches/krb5-1-9/src/lib/gssapi/krb5/acquire_cred.c
===================================================================
--- branches/krb5-1-9/src/lib/gssapi/krb5/acquire_cred.c	2010-11-01 20:36:17 UTC (rev 24495)
+++ branches/krb5-1-9/src/lib/gssapi/krb5/acquire_cred.c	2010-11-01 20:36:22 UTC (rev 24496)
@@ -190,8 +190,7 @@
         krb5_kt_free_entry(context, &entry);
 
         assert(cred->name == NULL);
-        code = kg_init_name(context, desired_princ, NULL,
-                            KG_INIT_NAME_INTERN, &cred->name);
+        code = kg_init_name(context, desired_princ, NULL, 0, &cred->name);
         if (code) {
             *minor_status = code;
             return GSS_S_FAILURE;
@@ -384,8 +383,7 @@
      */
     if (cred->name == NULL) {
         if ((code = kg_init_name(context, ccache_princ, NULL,
-                                 KG_INIT_NAME_NO_COPY | KG_INIT_NAME_INTERN,
-                                 &cred->name))) {
+                                 KG_INIT_NAME_NO_COPY, &cred->name))) {
             krb5_free_principal(context, ccache_princ);
             krb5_cc_close(context, ccache);
             *minor_status = code;




More information about the cvs-krb5 mailing list