svn rev #24083: trunk/src/kadmin/cli/

[ghudson@MIT.EDU]

http://src.mit.edu/fisheye/changelog/krb5/?cs=24083
Commit By: ghudson
Log Message:
Remove an unneeded conditional in the cleanup for kadmin's keytab
add_principal(), squashing a false-positive memory leak from Coverity.



Changed Files:
U   trunk/src/kadmin/cli/keytab.c
Modified: trunk/src/kadmin/cli/keytab.c
===================================================================
--- trunk/src/kadmin/cli/keytab.c	2010-05-21 19:08:41 UTC (rev 24082)
+++ trunk/src/kadmin/cli/keytab.c	2010-05-21 19:15:20 UTC (rev 24083)
@@ -334,11 +334,9 @@
     }
 
 cleanup:
-    if (nkeys) {
-        for (i = 0; i < nkeys; i++)
-            krb5_free_keyblock_contents(context, &keys[i]);
-        free(keys);
-    }
+    for (i = 0; i < nkeys; i++)
+        krb5_free_keyblock_contents(context, &keys[i]);
+    free(keys);
     krb5_free_principal(context, princ);
 }