svn rev #24066: branches/krb5-1-7/src/kdc/

tlyu@MIT.EDU tlyu at MIT.EDU
Wed May 19 17:23:14 EDT 2010


http://src.mit.edu/fisheye/changelog/krb5/?cs=24066
Commit By: tlyu
Log Message:
ticket: 6728
target_version: 1.7.2
version_fixed: 1.7.2
tags: pullup
subject: memory leak in process_tgs_req in r23724
status: resolved

pull up r23959 from trunk

 ------------------------------------------------------------------------
 r23959 | tlyu | 2010-04-30 17:10:55 -0400 (Fri, 30 Apr 2010) | 8 lines

 ticket: 6711
 subject: memory leak in process_tgs_req in r23724
 tags: pullup
 target_version: 1.8.2

 Fix a KDC memory leak that was introduced by r23724 that could leak
 the decoded request.


Changed Files:
U   branches/krb5-1-7/src/kdc/do_tgs_req.c
Modified: branches/krb5-1-7/src/kdc/do_tgs_req.c
===================================================================
--- branches/krb5-1-7/src/kdc/do_tgs_req.c	2010-05-19 21:23:09 UTC (rev 24065)
+++ branches/krb5-1-7/src/kdc/do_tgs_req.c	2010-05-19 21:23:14 UTC (rev 24066)
@@ -135,8 +135,10 @@
     retval = decode_krb5_tgs_req(pkt, &request);
     if (retval)
         return retval;
-    if (request->msg_type != KRB5_TGS_REQ)
+    if (request->msg_type != KRB5_TGS_REQ) {
+        krb5_free_kdc_req(kdc_context, request);
         return KRB5_BADMSGTYPE;
+    }
 
     /*
      * setup_server_realm() sets up the global realm-specific data pointer.




More information about the cvs-krb5 mailing list