svn rev #23922: trunk/src/kdc/

ghudson@MIT.EDU ghudson at MIT.EDU
Wed Apr 21 23:44:45 EDT 2010


http://src.mit.edu/fisheye/changelog/krb5/?cs=23922
Commit By: ghudson
Log Message:
Eliminate a non-useful NULL check in the KDC's dispatch() function.
If process_as_req or process_tgs_req return successfully, they will
always fill in *response.  (If they didn't, the subsequence
(*response)->length check would crash anyway.)



Changed Files:
U   trunk/src/kdc/dispatch.c
Modified: trunk/src/kdc/dispatch.c
===================================================================
--- trunk/src/kdc/dispatch.c	2010-04-22 03:19:34 UTC (rev 23921)
+++ trunk/src/kdc/dispatch.c	2010-04-22 03:44:44 UTC (rev 23922)
@@ -111,7 +111,7 @@
         retval = KRB5KRB_AP_ERR_MSG_TYPE;
 #ifndef NOCACHE
     /* put the response into the lookaside buffer */
-    if (!retval && *response != NULL)
+    if (!retval)
         kdc_insert_lookaside(pkt, *response);
 #endif
 




More information about the cvs-krb5 mailing list