svn rev #22800: branches/krb5-1-7/src/lib/krb5/rcache/

tlyu@MIT.EDU tlyu at MIT.EDU
Mon Sep 28 16:58:54 EDT 2009


http://src.mit.edu/fisheye/changelog/krb5/?cs=22800
Commit By: tlyu
Log Message:
ticket: 6514
version_fixed: 1.7.1
status: resolved

pull up r22417 from trunk

 ------------------------------------------------------------------------
 r22417 | raeburn | 2009-06-18 17:56:48 -0400 (Thu, 18 Jun 2009) | 13 lines

 ticket: 6514
 subject: minor memory leak in 'none' replay cache type
 tags: pullup
 target_version: 1.7.1
 version_reported: 1.7

 The replay cache type implementations are responsible for freeing the
 main rcache structure when the cache handle is closed.  The 'none'
 rcache type wasn't doing this, resulting in a small memory leak each
 time such a cache was opened and closed.  Not a big deal for a server
 process servicing a single client, but it could accumulate (very very
 slowly) for a long-running server.


Changed Files:
U   branches/krb5-1-7/src/lib/krb5/rcache/rc_none.c
Modified: branches/krb5-1-7/src/lib/krb5/rcache/rc_none.c
===================================================================
--- branches/krb5-1-7/src/lib/krb5/rcache/rc_none.c	2009-09-28 20:44:23 UTC (rev 22799)
+++ branches/krb5-1-7/src/lib/krb5/rcache/rc_none.c	2009-09-28 20:58:54 UTC (rev 22800)
@@ -44,11 +44,17 @@
     return 0;
 }
 #define krb5_rc_none_recover    krb5_rc_none_noargs
-#define krb5_rc_none_destroy    krb5_rc_none_noargs
-#define krb5_rc_none_close      krb5_rc_none_noargs
 #define krb5_rc_none_expunge    krb5_rc_none_noargs
 
 static krb5_error_code KRB5_CALLCONV
+krb5_rc_none_close(krb5_context ctx, krb5_rcache rc)
+{
+    free (rc);
+    return 0;
+}
+#define krb5_rc_none_destroy    krb5_rc_none_close
+
+static krb5_error_code KRB5_CALLCONV
 krb5_rc_none_store(krb5_context ctx, krb5_rcache rc, krb5_donot_replay *r)
 {
     return 0;




More information about the cvs-krb5 mailing list