svn rev #22750: trunk/src/kdc/

epeisach@MIT.EDU epeisach at MIT.EDU
Sun Sep 13 22:03:29 EDT 2009


http://src.mit.edu/fisheye/changelog/krb5/?cs=22750
Commit By: epeisach
Log Message:
ticket: 6564
status: open

Initialize several variables - so that on error cleanup - we do not try to free
bogus memory.

The ticket is still open as the kproplog test is failing - but no coredump.




Changed Files:
U   trunk/src/kdc/do_tgs_req.c
Modified: trunk/src/kdc/do_tgs_req.c
===================================================================
--- trunk/src/kdc/do_tgs_req.c	2009-09-13 22:37:40 UTC (rev 22749)
+++ trunk/src/kdc/do_tgs_req.c	2009-09-14 02:03:28 UTC (rev 22750)
@@ -130,6 +130,9 @@
     krb5_pa_data *pa_tgs_req; /*points into request*/
     krb5_data scratch;
 
+    reply.padata = 0; /* For cleanup handler */
+    reply_encpart.enc_padata = 0;
+
     session_key.contents = NULL;
 
     retval = decode_krb5_tgs_req(pkt, &request);
@@ -866,7 +869,6 @@
     ticket_reply.enc_part.kvno = ticket_kvno;
     /* Start assembling the response */
     reply.msg_type = KRB5_TGS_REP;
-    reply.padata = 0;/* always */
     if (isflagset(c_flags, KRB5_KDB_FLAG_PROTOCOL_TRANSITION) &&
         find_pa_data(request->padata, KRB5_PADATA_S4U_X509_USER) != NULL) {
         errcode = kdc_make_s4u2self_rep(kdc_context,




More information about the cvs-krb5 mailing list