svn rev #21909: trunk/src/lib/krb5/krb/

ghudson@MIT.EDU ghudson at MIT.EDU
Fri Feb 6 13:40:16 EST 2009


http://src.mit.edu/fisheye/changelog/krb5/?cs=21909
Commit By: ghudson
Log Message:
ticket: 6375
subject: Fix error handling in krb5_walk_realm_tree
tags: pullup
target_version: 1.7

rtree_hier_realms was forgetting to assign the return value of
krb5int_copy_data_contents to retval, which would cause a failure to
notice out-of-memory conditions.



Changed Files:
U   trunk/src/lib/krb5/krb/walk_rtree.c
Modified: trunk/src/lib/krb5/krb/walk_rtree.c
===================================================================
--- trunk/src/lib/krb5/krb/walk_rtree.c	2009-02-06 05:42:32 UTC (rev 21908)
+++ trunk/src/lib/krb5/krb/walk_rtree.c	2009-02-06 18:40:04 UTC (rev 21909)
@@ -389,7 +389,7 @@
     }
     /* Copy server realm "tweens" backward. */
     for (twp = &stweens[nstween]; twp-- > stweens;) {
-	krb5int_copy_data_contents(context, twp, rp++);
+	retval = krb5int_copy_data_contents(context, twp, rp++);
 	if (retval) goto error;
     }
 error:




More information about the cvs-krb5 mailing list