svn rev #21887: trunk/src/ lib/gssapi/krb5/

[raeburn@MIT.EDU]

http://src.mit.edu/fisheye/changelog/krb5/?cs=21887
Commit By: raeburn
Log Message:
ticket: 6363
subject: int/ptr bug in gssapi code
target_version: 1.7
tags: pullup

Fix a pointer argument passed where an integer is needed.
Update Sun compiler options to make that an error.  (The options we're
currently using make it an error for assignment but not for argument passing.)


Changed Files:
U   trunk/src/aclocal.m4
U   trunk/src/lib/gssapi/krb5/k5seal.c
Modified: trunk/src/aclocal.m4
===================================================================
--- trunk/src/aclocal.m4	2009-02-04 23:28:09 UTC (rev 21886)
+++ trunk/src/aclocal.m4	2009-02-05 01:49:21 UTC (rev 21887)
@@ -664,7 +664,7 @@
     # works, but it also means that declaration-in-code warnings won't
     # be issued.
     # -v -fd -errwarn=E_DECLARATION_IN_CODE ...
-    WARN_CFLAGS="-errtags=yes -errwarn=E_BAD_PTR_INT_COMBINATION -errwarn=E_PTR_TO_VOID_IN_ARITHMETIC"
+    WARN_CFLAGS="-errtags=yes -errwarn=E_BAD_PTR_INT_COMBINATION -errwarn=E_BAD_PTR_INT_COMB_ARG -errwarn=E_PTR_TO_VOID_IN_ARITHMETIC"
     WARN_CXXFLAGS="-errtags=yes +w +w2 -xport64"
   fi
 fi

Modified: trunk/src/lib/gssapi/krb5/k5seal.c
===================================================================
--- trunk/src/lib/gssapi/krb5/k5seal.c	2009-02-04 23:28:09 UTC (rev 21886)
+++ trunk/src/lib/gssapi/krb5/k5seal.c	2009-02-05 01:49:21 UTC (rev 21887)
@@ -258,7 +258,7 @@
             unsigned char bigend_seqnum[4];
             krb5_keyblock *enc_key;
             int i;
-            store_32_be(seqnum, bigend_seqnum);
+            store_32_be(*seqnum, bigend_seqnum);
             code = krb5_copy_keyblock (context, enc, &enc_key);
             if (code)
             {