svn rev #23533: trunk/src/ kdc/ lib/kadm5/

[tlyu@MIT.EDU]

http://src.mit.edu/fisheye/changelog/krb5/?cs=23533
Commit By: tlyu
Log Message:
ticket: 6608
subject: MITKRB5-SA-2009-003 CVE-2009-3295 KDC null deref in referrals
tags: pullup
target_version: 1.7.1

On certain error conditions, prep_reprocess_req() calls kdc_err() with
a null pointer as the format string, causing a null dereference and
denial of service.  Legitimate protocol requests can trigger this
problem.


Changed Files:
U   trunk/src/kdc/do_tgs_req.c
U   trunk/src/lib/kadm5/logger.c
Modified: trunk/src/kdc/do_tgs_req.c
===================================================================
--- trunk/src/kdc/do_tgs_req.c	2009-12-28 20:13:39 UTC (rev 23532)
+++ trunk/src/kdc/do_tgs_req.c	2009-12-29 02:42:51 UTC (rev 23533)
@@ -1251,7 +1251,7 @@
             free(temp_buf);
             if (retval) {
                 /* no match found */
-                kdc_err(kdc_context, retval, 0);
+                kdc_err(kdc_context, retval, "unable to find realm of host");
                 goto cleanup;
             }
             if (realms == 0) {

Modified: trunk/src/lib/kadm5/logger.c
===================================================================
--- trunk/src/lib/kadm5/logger.c	2009-12-28 20:13:39 UTC (rev 23532)
+++ trunk/src/lib/kadm5/logger.c	2009-12-29 02:42:51 UTC (rev 23533)
@@ -189,6 +189,9 @@
     char        *cp;
     char        *syslogp;
 
+    if (whoami == NULL || format == NULL)
+        return;
+
     /* Make the header */
     snprintf(outbuf, sizeof(outbuf), "%s: ", whoami);
     /*