svn rev #22247: branches/krb5-1-7/src/util/ss/

[tlyu@MIT.EDU]

http://src.mit.edu/fisheye/changelog/krb5/?cs=22247
Commit By: tlyu
Log Message:
ticket: 6442
version_fixed: 1.7

pull up r22172 from trunk
 ------------------------------------------------------------------------
 r22172 | epeisach | 2009-04-07 13:57:56 -0400 (Tue, 07 Apr 2009) | 9 lines
 Changed paths:
    M /trunk/src/util/ss/help.c

 ticket: 6442
 subject: Null pointer defref in adding info

 Clearly the code is broken - and we either never use it - or callers never pass
 NULL...

 Detected by clang static checker.


Changed Files:
U   branches/krb5-1-7/src/util/ss/help.c
Modified: branches/krb5-1-7/src/util/ss/help.c
===================================================================
--- branches/krb5-1-7/src/util/ss/help.c	2009-04-15 20:07:24 UTC (rev 22246)
+++ branches/krb5-1-7/src/util/ss/help.c	2009-04-15 20:07:26 UTC (rev 22247)
@@ -107,7 +107,7 @@
     register char **dirs;
 
     info = ss_info(sci_idx);
-    if (info_dir == NULL && *info_dir) {
+    if ((info_dir == NULL) || (*info_dir == '\0')) {
 	*code_ptr = SS_ET_NO_INFO_DIR;
 	return;
     }