svn rev #22183: trunk/src/kdc/

epeisach@MIT.EDU epeisach at MIT.EDU
Wed Apr 8 11:25:44 EDT 2009


http://src.mit.edu/fisheye/changelog/krb5/?cs=22183
Commit By: epeisach
Log Message:
ticket: 6449
subject: Fall through on error return

If decoding the encoded_req_body fails, proceed goto errout instead of falling
through to fast handling.

Looks like a merge error.

Reindented code.




Changed Files:
U   trunk/src/kdc/do_as_req.c
Modified: trunk/src/kdc/do_as_req.c
===================================================================
--- trunk/src/kdc/do_as_req.c	2009-04-08 15:22:17 UTC (rev 22182)
+++ trunk/src/kdc/do_as_req.c	2009-04-08 15:25:43 UTC (rev 22183)
@@ -144,9 +144,10 @@
     }
     if (fetch_asn1_field((unsigned char *) req_pkt->data,
 			 1, 4, &encoded_req_body) != 0) {
-    errcode = ASN1_BAD_ID;
-    status = "Finding req_body";
-}
+        errcode = ASN1_BAD_ID;
+        status = "Finding req_body";
+	goto errout;
+    }
     errcode = kdc_find_fast(&request, &encoded_req_body, NULL /*TGS key*/, NULL, state);
     if (errcode) {
 	status = "error decoding FAST";




More information about the cvs-krb5 mailing list