svn rev #20122: branches/krb5-1-6/ src/windows/installer/wix/ src/windows/installer/wix/custom/ ...

[tlyu@MIT.EDU]

Commit By: tlyu
Log Message: 
ticket: 5820
version_fixed: 1.6.3

pull up r20119 from trunk

 r20119 at cathode-dark-space:  jaltman | 2007-10-12 19:08:30 -0400
 ticket: 5820
 
 There appears to be a bug either in the WiX engine or the Windows Installer 3.1.
 The "File" type on the Registry Search property is supposed to provide the full 
 path name.  Instead, we are being given just the directory as if it were being 
 processed with the "Directory" type.
 
 We can avoid this for a REG_SZ value by using the "Raw" type because we are 
 sure that the string is not going to begin with a '#' character.  
 
 Because the full path was not being obtained for the UPGRADENSIS property, the
 Uninstall routine was unable to CreateProcess() the uninstall program.  
 
 This commit also includes addition debugging in the NSIS Uninstall custom
 handler to report the path and the GetLastError() value when the uninstall 
 fails.  This will be logged in the msiexec log file and displayed in a 
 MessageBox.
 
 
 




Changed Files:
_U  branches/krb5-1-6/
U   branches/krb5-1-6/src/windows/installer/wix/custom/custom.cpp
U   branches/krb5-1-6/src/windows/installer/wix/custom/custom.h
U   branches/krb5-1-6/src/windows/installer/wix/lang/ui_1033.wxi
U   branches/krb5-1-6/src/windows/installer/wix/property.wxi