<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Hi Don/Raj,<div><br></div><div>I've merged your pull request with minor changes so you should be able to test that the latest load balancer code doesn't add more nodes than it should (ie beyond max size). Don't forget to grab the latest code before testing. I'm still working on the addnode failures you encountered which I don't believe has anything to do with EBS vs instance-store timing. I'll post updates when I have new code to test.</div><div><br></div><div><div><div>On Jun 2, 2011, at 9:21 AM, Don MacMillen wrote:</div><blockquote type="cite"><div>Another quick question: Does 'starcluster terminate <clustername>'</div><div>call the 'on_remove_node' method of the plugin? It looks like</div><div>it does not but apologies if this is documented already. From our</div>
<div>point of view, it would be useful for the terminate cluster command</div><div>to call this method.</div></blockquote><br></div><div>Stop/Terminate doesn't call on_remove_node but instead calls on_shutdown. The main difference is that on_shutdown receives *all* the nodes and is not called for each individual node to be removed. Will this work for you? You can browse the available plugin methods called by StarCluster in clustersetup.py:</div><div><br></div><div><a href="https://github.com/jtriley/StarCluster/blob/master/starcluster/clustersetup.py">https://github.com/jtriley/StarCluster/blob/master/starcluster/clustersetup.py</a></div><div><br></div><div>Specifically look at the ClusterSetup base class. </div><div><br></div><div>HTH,</div><div><br></div><div>~Justin</div><br></div></body></html>