<div dir="ltr">Just noticed that I had only responded to Laura and missed cc-ing the list. I'm glad that we all came up with the same recommendation :-)<div><br></div><div>@Brendan: Is there a setting for the list to automatically add itself as the reply-to address?<br></div><div><br></div><div>M.</div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">---------- Forwarded message ---------<br>From: <strong class="gmail_sendername" dir="auto">Manolis Stamatogiannakis</strong> <span dir="auto"><<a href="mailto:mstamat@gmail.com">mstamat@gmail.com</a>></span><br>Date: Mon, 14 Oct 2019 at 13:59<br>Subject: Re: [panda-users] syscalls2 and reserved words<br>To: Mann, Laura L [US] (MS) <<a href="mailto:laura.mann@ngc.com">laura.mann@ngc.com</a>><br></div><br><br><div dir="ltr"><div>"cpu" is reserved so that it doesn't conflict with the CPUState* cpu argument we have in the plugin callback definitions.</div><div><br></div><div>I'm not sure about "data" though. It has been propagated forward from the PANDA1 version of the script [1]. >From what I can tell, we should be fine if we remove it from the reserved words list - you can give it a try and see if anything breaks.</div><div><br></div><div>On the other hand, reserved words are just prefixed with "_" if they occur as argument names. So it should be harmless to list a word as reserved, even if it doesn't cause any problems.</div><div><br></div><div>For the 64bit linux support you can probably ignore reserved words. If there is a word that needs to be added, the compiler will be very vocal reminding you :-)</div><div><br></div><div>M.</div><div><br></div><div>[1] <a href="https://github.com/panda-re/panda/blob/cef777afb37a157582a26614eadec9bda399c4be/panda/plugins/syscalls2/syscall_parser.py" target="_blank">https://github.com/panda-re/panda/blob/cef777afb37a157582a26614eadec9bda399c4be/panda/plugins/syscalls2/syscall_parser.py</a></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 14 Oct 2019 at 13:17, Mann, Laura L [US] (MS) <<a href="mailto:laura.mann@ngc.com" target="_blank">laura.mann@ngc.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="EN-US">
<div>
<p class="MsoNormal">We’re looking at updating the syscalls2 plugin to work with 64-bit linux. There’s a list of “reserved” words in the syscall_parser.py file that is used to determine what system call argument names need to be renamed. I understand why
“new” and “int” are in the list – they are C/C++ reserved words. But why are “cpu” and “data” in the list? Under what definition of “reserved” words do they fall?<u></u><u></u></p>
<p class="MsoNormal">There are some new system call argument names in the 64-bit system calls, and I want to ensure any which are “reserved” (under whatever definition is being used) are so indicated.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Thanks,<u></u><u></u></p>
<p class="MsoNormal">Laura L. Mann<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
_______________________________________________<br>
panda-users mailing list<br>
<a href="mailto:panda-users@mit.edu" target="_blank">panda-users@mit.edu</a><br>
<a href="http://mailman.mit.edu/mailman/listinfo/panda-users" rel="noreferrer" target="_blank">http://mailman.mit.edu/mailman/listinfo/panda-users</a><br>
</blockquote></div>
</div></div></div>