<div dir="ltr">Actually no. Worked like a charm after enabling.<div><br></div><div>I was expecting it was some incorrect argument, but I got mixed signals trying to figure it out: </div><div><br></div><div>USAGE.md doesn't mention the default value for pos (sentence cuts off).<br></div><div>The flag is initialized to true "bool positional_labels = true;". So if you stop reading there, you assume this should be the default.<br></div><div>But it isn't. The value is overwritten with the return value of panda_parse_bool() which defaults to false.</div><div><br></div><div>Will send a pull request to prevent more people from slipping :)</div><div><br></div><div>Thanks!<br><br></div><div>M.</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-08-01 16:47 GMT+02:00 Brendan Dolan-Gavitt <span dir="ltr"><<a href="mailto:brendandg@nyu.edu" target="_blank">brendandg@nyu.edu</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Are you using the "pos" option to file_taint to use a different label for each byte in the file?<div class="HOEnZb"><div class="h5"><span></span><br><br>On Monday, August 1, 2016, Manolis Stamatogiannakis <<a href="mailto:mstamat@gmail.com" target="_blank">mstamat@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks!<div>I'm using the file_taint plugin to apply taint.</div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-08-01 14:29 GMT+02:00 Hulin, Patrick - 0559 - MITLL <span dir="ltr"><<a>Patrick.Hulin@ll.mit.edu</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I think I can guess what the problem is. One second – let me take a look.<u></u><u></u></span></p><span><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> <a>panda-users-bounces@mit.edu</a> [mailto:<a>panda-users-bounces@mit.edu</a>] <b>On Behalf Of </b>Manolis Stamatogiannakis<br><b>Sent:</b> Monday, August 01, 2016 7:30 AM<br><b>To:</b> <a>panda-users@mit.edu</a><br><b>Subject:</b> [panda-users] taint labelset iteration<u></u><u></u></span></p><p class="MsoNormal"><u></u> <u></u></p></span><div><p class="MsoNormal">Hello,<u></u><u></u></p><div><div><div><p class="MsoNormal"><u></u> <u></u></p></div><div><p class="MsoNormal">I'm using the tain2 plugin and I'm trying to iterate over the taint labels of a buffer.<u></u><u></u></p></div><div><p class="MsoNormal">My code looks like this:<u></u><u></u></p></div><div><p class="MsoNormal"><u></u> <u></u></p></div><div><p class="MsoNormal">for (int32_t i=0; i<buflen; i++) {<u></u><u></u></p></div><div><p class="MsoNormal">uint32_t pa = panda_virt_to_phys(env, buf+i);<u></u><u></u></p></div><div><p class="MsoNormal">taint2_labelset_ram_iter(pa, label_print, NULL);<u></u><u></u></p><div><p class="MsoNormal">}<u></u><u></u></p></div><div><p class="MsoNormal"><u></u> <u></u></p></div><div><p class="MsoNormal">static int label_print(uint32_t el, void *sup) {<u></u><u></u></p></div><div><div><p class="MsoNormal">std::cout << " " << el;<u></u><u></u></p></div><div><p class="MsoNormal">return 0;<u></u><u></u></p></div><div><p class="MsoNormal">}<u></u><u></u></p></div></div></div><div><p class="MsoNormal"><u></u> <u></u></p></div><div><p class="MsoNormal">What doesn't seem right is that always the same value of 1 is printed. Am I missing something in the API/configuration that prevents this from working?<u></u><u></u></p></div><div><p class="MsoNormal"><u></u> <u></u></p></div><div><p class="MsoNormal">Thanks,<u></u><u></u></p></div><div><p class="MsoNormal">M.<u></u><u></u></p></div></div></div></div></div></div></blockquote></div><br></div>
</blockquote><br><br></div></div><span class="HOEnZb"><font color="#888888">-- <br>Brendan Dolan-Gavitt<br>Assistant Professor, Department of Computer Science and Engineering<br>NYU Tandon School of Engineering<br>
</font></span></blockquote></div><br></div>