<div dir="ltr">Just pulled a fix down to production, can you verify that it's working?<div><br></div><div>-Ed</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jun 11, 2013 at 4:22 PM, pablo rey <span dir="ltr"><<a href="mailto:pablo@basurama.org" target="_blank">pablo@basurama.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Ed,<div>Would you have time to fix this today? Thanks!</div><span class="HOEnZb"><font color="#888888"><div>
p</div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jun 10, 2013 at 2:26 PM, Edward Platt <span dir="ltr"><<a href="mailto:elplatt@media.mit.edu" target="_blank">elplatt@media.mit.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I'll switch from email to username asap!<div><br></div><div>-Ed</div></div><div><div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jun 10, 2013 at 2:24 PM, pablo rey <span dir="ltr"><<a href="mailto:pablo@basurama.org" target="_blank">pablo@basurama.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra">My answers bellow.</div><div class="gmail_extra"><br></div><div class="gmail_extra">
<b>One important security thing</b>: we should not let the auto-complete, when adding collaborators, find the user's email. I already pulled in production, and having all those emails available is not a good thing.</div>
<div>
<div class="gmail_extra"><br></div><div class="gmail_extra">On Mon, Jun 10, 2013 at 12:42 PM, Edward Platt <span dir="ltr"><<a href="mailto:elplatt@media.mit.edu" target="_blank">elplatt@media.mit.edu</a>></span> wrote:<br>
</div></div><div class="gmail_extra"><div class="gmail_quote"><div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Ah, I'll look into the add button.<div>
<br></div><div>Thoughts on making the icons more recognizable:</div>
<div>* We can switch to an identicon (unique geometric shape) for users who don't have gravatars.</div></div></blockquote></div><div>I'll make one.</div><div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr">
<div>* The icons are currently semi-transparent, should we make them fully opaque?</div></div></blockquote></div><div>To keep the page visualization clean we should display the icons only when you hover the area. The important thing is still the area, not the creator.</div>
<div>So make them opaque if we make it only appear when hovering.</div><div>You can preview it in this thread <a href="http://pageonex.com/matrushka/gezi-parki-protests-in-turkish-newspapers/coding/?i=haberturk-2013-06-09" target="_blank">http://pageonex.com/matrushka/gezi-parki-protests-in-turkish-newspapers/coding/?i=haberturk-2013-06-09</a> with 2 users.</div>
<div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div>* We can add the username, but I worry it might start to look cluttered.</div>
</div></blockquote>
</div><div>The same here, only when you hover over the icon, you can read the user's name.</div><div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr">
<div>* Also, should collaborators be identified by email or username? I went with email, just to get the functionality out, but we could switch to username.</div></div></blockquote></div><div>I like the idea of being able to use both username and email. If that's not possible, better username, so you don't have to ask users for their emails.</div>
<div><div>
<div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">
<div><br></div><div>-Ed</div></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jun 10, 2013 at 12:33 PM, pablo rey <span dir="ltr"><<a href="mailto:pablo@basurama.org" target="_blank">pablo@basurama.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div><div>Typing in works. The add button seem useless.<br>
<br>It looks great Ed! Great improvement.<br>
<br></div>Thinking on adding a tittle tag to the open id image on the area to know who is the coder, some people don't sue open id, or their icon is not recognizable. <br>
<br></div><div>Also it might be good to list the collaborators in the display view. thoughts?<br><br>Collaborating is what I've been doing in the Turkish thread using my admin superpowers :)<br></div></div><div>
<div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Mon, Jun 10, 2013 at 11:28 AM, Edward Platt <span dir="ltr"><<a href="mailto:elplatt@media.mit.edu" target="_blank">elplatt@media.mit.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr">Try typing it in, does it show up in the autocomplete list?</div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jun 10, 2013 at 11:26 AM, pablo rey <span dir="ltr"><<a href="mailto:pablo@basurama.org" target="_blank">pablo@basurama.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">I copy pasted one of the users emails, but I didn't check if it was already a collaborator. I don't think so, I just had enabled the feature, just had pulled to dev.<div>
<div><br><br>On Monday, June 10, 2013, Edward Platt <<a href="mailto:elplatt@media.mit.edu" target="_blank">elplatt@media.mit.edu</a>> wrote:<br>
> Can you verify that the email actually exists? It only allows you to add existing users who aren't already collaborators. I should add error messages for when the entered user isn't valid.<br>> -Ed<br>><br>
> On Mon, Jun 10, 2013 at 1:01 AM, pablo rey <<a href="mailto:pablo@basurama.org" target="_blank">pablo@basurama.org</a>> wrote:<br>>><br>>> hi Ed,<br>>><br>>> I saw you commits about adding collaborators to a thread, and I pulled it to dev, but ir is not working. I put one of the user emails, clicked "add" but nothing happens. Is this feture ready? I might be doing somethin wrong.<br>
>> p<br>>><br>>> ps. the thread on Turkish protests on Turkish newspapers <a href="http://pageonex.com/matrushka/gezi-parki-protests-in-turkish-newspapers/" target="_blank">http://pageonex.com/matrushka/gezi-parki-protests-in-turkish-newspapers/</a> got 1000+ visits, specially from Turkey (and from facebook).<br>
>> _______________________________________________<br>>> Pageonexdev mailing list<br>>> <a href="mailto:Pageonexdev@mit.edu" target="_blank">Pageonexdev@mit.edu</a><br>>> <a href="http://mailman.mit.edu/mailman/listinfo/pageonexdev" target="_blank">http://mailman.mit.edu/mailman/listinfo/pageonexdev</a><br>
>><br>><br>><br>><br>> --<br>> Edward L. Platt<br>> Civic Technology Programmer<br>> MIT Center for Civic Media<br>> E15-348<br>> <a href="http://civic.mit.edu" target="_blank">http://civic.mit.edu</a><br>
> <a href="http://elplatt.com" target="_blank">http://elplatt.com</a><br>> @EdwardLPlatt
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Edward L. Platt<br></div><div>Civic Technology Programmer</div><div>MIT Center for Civic Media</div><div>E15-348</div><div><a href="http://civic.mit.edu" target="_blank">http://civic.mit.edu</a></div>
<div><a href="http://elplatt.com" target="_blank">http://elplatt.com</a></div><div><a href="http://twitter.com/edwardlplatt" target="_blank">@EdwardLPlatt</a></div>
</div>
</div></div><br>_______________________________________________<br>
Pageonexdev mailing list<br>
<a href="mailto:Pageonexdev@mit.edu" target="_blank">Pageonexdev@mit.edu</a><br>
<a href="http://mailman.mit.edu/mailman/listinfo/pageonexdev" target="_blank">http://mailman.mit.edu/mailman/listinfo/pageonexdev</a><br>
<br></blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Edward L. Platt<br></div><div>Civic Technology Programmer</div><div>MIT Center for Civic Media</div><div>E15-348</div><div><a href="http://civic.mit.edu" target="_blank">http://civic.mit.edu</a></div>
<div><a href="http://elplatt.com" target="_blank">http://elplatt.com</a></div><div><a href="http://twitter.com/edwardlplatt" target="_blank">@EdwardLPlatt</a></div>
</div>
</div></div><br>_______________________________________________<br>
Pageonexdev mailing list<br>
<a href="mailto:Pageonexdev@mit.edu" target="_blank">Pageonexdev@mit.edu</a><br>
<a href="http://mailman.mit.edu/mailman/listinfo/pageonexdev" target="_blank">http://mailman.mit.edu/mailman/listinfo/pageonexdev</a><br>
<br></blockquote></div></div></div><br></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Edward L. Platt<br></div><div>Civic Technology Programmer</div><div>MIT Center for Civic Media</div><div>E15-348</div><div><a href="http://civic.mit.edu" target="_blank">http://civic.mit.edu</a></div>
<div><a href="http://elplatt.com" target="_blank">http://elplatt.com</a></div><div><a href="http://twitter.com/edwardlplatt" target="_blank">@EdwardLPlatt</a></div>
</div>
</div></div><br>_______________________________________________<br>
Pageonexdev mailing list<br>
<a href="mailto:Pageonexdev@mit.edu" target="_blank">Pageonexdev@mit.edu</a><br>
<a href="http://mailman.mit.edu/mailman/listinfo/pageonexdev" target="_blank">http://mailman.mit.edu/mailman/listinfo/pageonexdev</a><br>
<br></blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Edward L. Platt<br></div><div>Civic Technology Programmer</div><div>MIT Center for Civic Media</div><div>E15-348</div><div><a href="http://civic.mit.edu" target="_blank">http://civic.mit.edu</a></div>
<div><a href="http://elplatt.com" target="_blank">http://elplatt.com</a></div><div><a href="http://twitter.com/edwardlplatt" target="_blank">@EdwardLPlatt</a></div>
</div>