Missing -lpthreads breaks build in plugins/tls/k5tls on AIX

[Benjamin Kaduk]

On Thu, Aug 24, 2017 at 10:19:08AM +0000, REIX, Tony wrote:
> Hummmm It is more complicated since Makefile is generated by Makefile.in .
> So my easy patch was removed by a rebuild from scratch.
> And TLS_IMPL_LIBS appears only in: /plugins/tls/k5tls/Makefile.in as :
> SHLIB_EXPLIBS= $(KRB5_LIB) $(SUPPORT_LIB) $(TLS_IMPL_LIBS)
> 
> Hummmm Looks like the issue is there:
> configure.in:    TLS_IMPL_LIBS="-lssl -lcrypto"
> configure:       TLS_IMPL_LIBS="-lssl -lcrypto"

IIRC, openssl only started requiring pthreads as of the 1.1.0 release;
could you confirm what version of openssl you are using?

I also thought that it was more portable to use the -pthread argument
(which does not necessarily translate to a new library dependency,
depending on the platform) than explictly linking a pthread implementation.

Also, does your openssl packaging provide a pkgconfig file or similar?
That seems like it would be a more portable way of picking up new
depnedencies than hardcoding it in configure.in.

-Ben