[krbdev.mit.edu #8502] ret_boolean in profile_get_boolean() should be krb5_boolean * instead of int *

Will Fiveash via RT rt-comment at krbdev.mit.edu
Thu Sep 29 12:54:39 EDT 2016


Otherwise I see compile errors like:
"../../../../mit-krb5/src/lib/krb5/os/locate_kdc.c", line 82: argument
#6 is incompatible with prototype:
	prototype: pointer to int : "../../../include/profile.h", line 89
	argument : pointer to unsigned int (E_ARG_INCOMPATIBLE_WITH_ARG_L)
cc: acomp failed for ../../../../mit-krb5/src/lib/krb5/os/locate_kdc.c

which involve:

use_dns_uri(krb5_context ctx)
{
    krb5_error_code ret;
    krb5_boolean use;

    ret = profile_get_boolean(ctx->profile, KRB5_CONF_LIBDEFAULTS,
                              KRB5_CONF_DNS_URI_LOOKUP, NULL,
                              DEFAULT_URI_LOOKUP, &use); <<< use is
krb5_boolean which is unsigned int.

but:

use_dns_uri(krb5_context ctx)
{
    krb5_error_code ret;
    krb5_boolean use;

    ret = profile_get_boolean(ctx->profile, KRB5_CONF_LIBDEFAULTS,
                              KRB5_CONF_DNS_URI_LOOKUP, NULL,
                              DEFAULT_URI_LOOKUP, &use);

This is preventing use of stricter compile flags.


More information about the krb5-bugs mailing list