[krbdev.mit.edu #7861] git commit

Greg Hudson via RT rt-comment at krbdev.mit.edu
Thu Feb 20 16:39:35 EST 2014


Simplify iprop update locking and avoid deadlock

Since we are no longer treating the update log like a journal (#7552),
we don't need two-stage update logging.  In kdb5.c, add an update log
entry after each DB change in one step, without getting an explicit
lock.  In kdb_log.c, combine ulog_add_update with ulog_finish_update,
and make ulog_add_update lock the ulog internally.

This change avoids deadlock by removing the only cases where the ulog
is locked before the DB.

https://github.com/krb5/krb5/commit/444ef5fe9ec8d64a5db27b3a8aaf6813dd7ef0e0
Author: Greg Hudson <ghudson at mit.edu>
Commit: 444ef5fe9ec8d64a5db27b3a8aaf6813dd7ef0e0
Branch: master
 src/include/kdb_log.h |    2 -
 src/lib/kdb/kdb5.c    |  116 ++++++++-----------------------------------------
 src/lib/kdb/kdb_log.c |   59 ++++++++-----------------
 3 files changed, 37 insertions(+), 140 deletions(-)



More information about the krb5-bugs mailing list