[krbdev.mit.edu #7760] [PATCH] Don't assume function arguments are evaluated right-to-left

[Tom Yu via RT]

"Mark H Weaver via RT" <rt-comment at krbdev.mit.edu> writes:

> "Greg Hudson via RT" <rt-comment at krbdev.mit.edu> writes:
>
>> This was fixed on master in commit 
>> 525eafc83a0fbe8f215b7749b5774d54468a19d1 (March 2013).
>
> If the problem was fixed in March, why is the bug still present in
> 1.11.4, released a few days ago?

We have a process for designating which commits should be applied to
prior release branches.  This commit was not designated in that way,
but now that we are aware of the need for this patch, we can include
it in a subsequent krb5-1.11 release.

>> Unless it is causing a build failure, I don't think there is a need to
>> backport the fix to prior releases since the bug is in a test program.
>
> It _does_ cause a build failure, because you pass options to GCC that
> turn that warning into a fatal error.

Thank you for letting us know about the build failure you experienced.
It appears that the bug does not cause a build failure on the
platforms where we regularly build krb5-1.11, so we did not consider
it a priority to apply the patch to the krb5-1.11 branch.  Now that we
are aware of the build failure, we have a justification for applying
the patch.

> In any case, without my patch 1.11.4 fails to build at all on my system.
> With the patch, it builds and passes the test suite.

Please let us know if the commit that Greg mentioned also fixes the
build for you.