[krbdev.mit.edu #7192] SVN Commit

Benjamin Kaduk via RT rt-comment at krbdev.mit.edu
Fri Jul 6 14:07:51 EDT 2012


Enable all localizations in main functions

Bite the bullet and pass LC_ALL to setlocale() instead of just
LC_MESSAGES.  Calls to setlocale() itself were introduced in
fabbf9e443459e8c0161c84563690ed70c7f6a61 for ticket 6918, but
only for LC_MESSAGES since only localized strings were needed
and that was the most conservative option.
However, klist, kadmin, and kinit (and perhaps others) would benefit
from localized formats for times (i.e., LC_TIME).  If potentially
localized data is being sent on the wire, that is a bug that should
be fixed.  No such bugs are found with the current test suite, so we
are comfortable enabling LC_ALL at this time.

https://github.com/krb5/krb5/commit/75c7c600b49a7f1d5cf95260fc073cb4ba5929cd
Author: Ben Kaduk <kaduk at mit.edu>
Commit: 75c7c600b49a7f1d5cf95260fc073cb4ba5929cd
Branch: master
 src/clients/kdestroy/kdestroy.c                 |    2 +-
 src/clients/kinit/kinit.c                       |    2 +-
 src/clients/klist/klist.c                       |    2 +-
 src/clients/kpasswd/kpasswd.c                   |    2 +-
 src/clients/kswitch/kswitch.c                   |    2 +-
 src/clients/kvno/kvno.c                         |    2 +-
 src/kadmin/cli/ss_wrapper.c                     |    2 +-
 src/kadmin/dbutil/kdb5_util.c                   |    2 +-
 src/kadmin/ktutil/ktutil.c                      |    2 +-
 src/kadmin/server/ovsec_kadmd.c                 |    2 +-
 src/kadmin/testing/scripts/env-setup.shin       |    5 +++--
 src/kdc/main.c                                  |    2 +-
 src/plugins/kdb/ldap/ldap_util/kdb5_ldap_util.c |    2 +-
 src/slave/kprop.c                               |    2 +-
 src/slave/kpropd.c                              |    2 +-
 src/slave/kproplog.c                            |    2 +-
 src/tests/dejagnu/config/default.exp            |    7 ++++---
 src/tests/misc/test_chpw_message.c              |    2 +-
 src/util/k5test.py                              |    5 +++--
 19 files changed, 26 insertions(+), 23 deletions(-)



More information about the krb5-bugs mailing list