[krbdev.mit.edu #6656] SVN Commit

[Tom Yu via RT]

pull up r23712, r23714 from trunk

 ------------------------------------------------------------------------
 r23714 | ghudson | 2010-02-09 20:55:36 -0500 (Tue, 09 Feb 2010) | 13 lines

 ticket: 6656

 Followon fixes to r23712:
 * A few formatting fixes.
 * Fix unlikely leak in kdc_handle_protected_negotiation: if
   add_pa_data_element with copy == FALSE fails, it's still the
   caller's responsibility to free pa.contents.
 * Fix pre-existing (since r23465) leak of reply_encpart.enc_padata in
   process_as_req.
 * Call add_pa_data_element with copy == TRUE in
   return_referral_enc_padata since we are passing memory owned by the
   database entry.

 ------------------------------------------------------------------------
 r23712 | hartmans | 2010-02-09 14:15:07 -0500 (Tue, 09 Feb 2010) | 14 lines

 subject: enc_padata can include empty sequence
 ticket: 6656
 target_version: 1.8
 tags: pullup

 There are two issues with return_enc_padata.
 1)  It often will return an empty sequence of enc_padata rather than not including the field
 2) FAST negotiation is double supported in the referral tgs path and not supported in the non-referral path

 Rewrite the return_enc_padata logic to:

 * Split  out referral interactions with kdb into its own function
 * Use add_pa_data_element

http://src.mit.edu/fisheye/changelog/krb5/?cs=23718
Commit By: tlyu
Revision: 23718
Changed Files:
U   branches/krb5-1-8/src/kdc/do_as_req.c
U   branches/krb5-1-8/src/kdc/do_tgs_req.c
U   branches/krb5-1-8/src/kdc/kdc_preauth.c
U   branches/krb5-1-8/src/kdc/kdc_util.c
U   branches/krb5-1-8/src/kdc/kdc_util.h