[krbdev.mit.edu #5488] build fails on solaris 2.6

Sun Mar 25 23:17:07 EDT 2007

>From krb5-bugs-incoming-bounces at PCH.MIT.EDU  Sun Mar 25 23:16:59 2007
Received: from pch.mit.edu (PCH.MIT.EDU [18.7.21.90]) by krbdev.mit.edu (8.12.9) with ESMTP
	id l2Q3GxL8018459; Sun, 25 Mar 2007 23:16:59 -0400 (EDT)
Received: from pch.mit.edu (pch.mit.edu [127.0.0.1])
	by pch.mit.edu (8.13.6/8.12.8) with ESMTP id l2Q3GswQ017855;
	Sun, 25 Mar 2007 23:16:54 -0400
Received: from fort-point-station.mit.edu (FORT-POINT-STATION.MIT.EDU
	[18.7.7.76])
	by pch.mit.edu (8.13.6/8.12.8) with ESMTP id l2NGOonj030472
	for <krb5-bugs-incoming at PCH.mit.edu>; Fri, 23 Mar 2007 12:24:50 -0400
Received: from mit.edu (W92-130-BARRACUDA-3.MIT.EDU [18.7.21.224])
	by fort-point-station.mit.edu (8.13.6/8.9.2) with ESMTP id
	l2NGOfho029230
	for <krb5-bugs at mit.edu>; Fri, 23 Mar 2007 12:24:41 -0400 (EDT)
Received: from srvtsbe10.itc.ads.t-systems.es (smtp2.t-systems.es
	[217.14.40.14]) by mit.edu (Spam Firewall) with ESMTP id AD64B37BD6F
	for <krb5-bugs at mit.edu>; Fri, 23 Mar 2007 12:24:40 -0400 (EDT)
Received: from SRVTSBC04.itc.ads.t-systems.es ([192.168.59.11]) by 
	srvtsbe10.itc.ads.t-systems.es with InterScan Message Security Suite;
	Fri, 23 Mar 2007 17:24:59 +0100
Received: from infoserver.vit.t-systems.es ([10.49.120.11]) by 
	SRVTSBC04.itc.ads.t-systems.es with Microsoft SMTPSVC(5.0.2195.6713);
	Fri, 23 Mar 2007 17:24:45 +0100
Received: from vit0102.vit.t-systems.es ([10.49.121.108]) by 
	infoserver.vit.t-systems.es with SMTP (Microsoft Exchange Internet Mail
	Service Version 5.5.2653.13)id H3T5TQMV; Fri, 23 Mar 2007 17:24:36 +0100
From: Aitor Oliveira <aitor.oliveira at t-systems.es>
Organization: T-Systems
To: krb5-bugs at mit.edu
Date: Fri, 23 Mar 2007 17:24:36 +0100
User-Agent: KMail/1.9.5
MIME-Version: 1.0
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200703231724.36437.aitor.oliveira at t-systems.es>
X-ExchangeSecure-AntiSpam: valid(50)
X-OriginalArrivalTime: 23 Mar 2007 16:24:45.0545 (UTC) 
	FILETIME=[C4E06D90:01C76D67]
X-imss-version: 2.046
X-imss-result: Passed
X-imss-scanInfo: M:T L:E SM:1
X-imss-tmaseResult: TT:1 TS:-15.3381 TC:1F TRN:36 TV:3.6.1039(15070.003)
X-imss-scores: Clean:100.00000 C:0 M:0 S:0 R:0
X-imss-settings: Baseline:2 C:1 M:1 S:1 R:1 (0.0000 0.0000)
X-Spam-Score: 2.42
X-Spam-Level: ** (2.42)
X-Spam-Flag: NO
X-Scanned-By: MIMEDefang 2.42
X-Mailman-Approved-At: Sun, 25 Mar 2007 23:16:52 -0400
X-BeenThere: krb5-bugs-incoming at mailman.mit.edu
X-Mailman-Version: 2.1.6
Precedence: list
Sender: krb5-bugs-incoming-bounces at PCH.MIT.EDU
Errors-To: krb5-bugs-incoming-bounces at PCH.MIT.EDU

>Submitter-Id:  net
>Originator:    Aitor Oliveira
>Organization:  T-Systems ITC
>Confidential:  no
>Synopsis:      build fails on solaris 2.6
>Severity:      serious
>Priority:      low
>Category:      krb5-build
>Class:         sw-bug
>Release:       1.6
>Environment:
System: SunOS xxxxxx 5.6 Generic_105181-39 sun4u sparc SUNW,Ultra-250
Architecture: sun4

>Description:
I found the same problem on kerberos mailing list: 2006-October/010739.html 
with release 1.5, but with no patch. The problem is that there are problems 
compiling on Solaris 2.6

First problem because no ipv6 in solaris 2.6, and missing some "#ifdef 
KRB5_USE_INET6", the problem is explained here: 
http://mailman.mit.edu/pipermail/kerberos/2006-October/010739.html

Second problem with addrinfo-test, details here:
http://mailman.mit.edu/pipermail/kerberos/2006-October/010759.html

>How-To-Repeat:
compiling on solaris 2.6
I used gcc 3.4.6 from sunfreeware and Solaris tools
./configure --without-krb4

>Fix:

FOR IPV6:

$ diff ./util/support/fake-addrinfo.c ./util/support/fake-addrinfo.c.bts
1331d1330
< #ifdef KRB5_USE_INET6
1333d1331
< #endif

$ diff ./lib/krb5/os/locate_kdc.c ./lib/krb5/os/locate_kdc.c.bts
567d566
< #ifdef KRB5_USE_INET6
569d567
< #endif
575d572
< #ifdef KRB5_USE_INET6
577,579d573
< #else
<     if (sa->sa_family != AF_INET)
< #endif
594d587
< #ifdef KRB5_USE_INET6
599d591
< #endif

$ diff ./tests/resolve/addrinfo-test.c ./tests/resolve/addrinfo-test.c.bts
59d58
< #ifdef KRB5_USE_INET6
61d59
< #endif
126d123
< #ifdef KRB5_USE_INET6
128d124
< #endif
197d192
< #ifdef KRB5_USE_INET6
201d195
< #endif

DON'T COMPILE addrinfo-test, because fails and it's just for testing

$ diff ./tests/resolve/Makefile ./tests/resolve/Makefile.bts
577,578c577
< #all:: resolve addrinfo-test fake-addrinfo-test
< all:: resolve
---
> all:: resolve addrinfo-test fake-addrinfo-test

This e-mail may contain confidential or privileged information. Any unauthorised
copying, use or distribution of this information is strictly prohibited.