[krbdev.mit.edu #5309]

[The RT System itself via RT]

>From krb5-bugs-incoming-bounces at PCH.mit.edu  Tue Jan  9 20:19:14 2007
Received: from pch.mit.edu (PCH.MIT.EDU [18.7.21.90]) by krbdev.mit.edu (8.9.3p2) with ESMTP
	id UAA07269; Tue, 9 Jan 2007 20:19:14 -0500 (EST)
Received: from pch.mit.edu (pch.mit.edu [127.0.0.1])
	by pch.mit.edu (8.13.6/8.12.8) with ESMTP id l0A1Iiuo008511;
	Tue, 9 Jan 2007 20:18:44 -0500
Received: from pacific-carrier-annex.mit.edu (PACIFIC-CARRIER-ANNEX.MIT.EDU
	[18.7.21.83])
	by pch.mit.edu (8.13.6/8.12.8) with ESMTP id l0A1Igae008508
	for <krb5-bugs-incoming at PCH.mit.edu>; Tue, 9 Jan 2007 20:18:42 -0500
Received: from mit.edu (W92-130-BARRACUDA-2.MIT.EDU [18.7.21.223])
	by pacific-carrier-annex.mit.edu (8.13.6/8.9.2) with ESMTP id
	l0A1IQiS019690
	for <krb5-bugs at mit.edu>; Tue, 9 Jan 2007 20:18:26 -0500 (EST)
Received: from sca-ea-mail-1.sun.com (sca-ea-mail-1.Sun.COM [192.18.43.24])
	(using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits))
	(No client certificate requested)
	by mit.edu (Spam Firewall) with ESMTP id 89351373D9E
	for <krb5-bugs at mit.edu>; Tue,  9 Jan 2007 20:18:25 -0500 (EST)
Received: from centralmail4brm.central.Sun.COM ([129.147.62.198])
	by sca-ea-mail-1.sun.com (8.13.7+Sun/8.12.9) with ESMTP id
	l0A1IN24013967
	for <krb5-bugs at mit.edu>; Tue, 9 Jan 2007 17:18:23 -0800 (PST)
Received: from alton.central.sun.com (alton.Central.Sun.COM [129.153.128.101])
	by centralmail4brm.central.Sun.COM (8.13.6+Sun/8.13.6/ENSMAIL,
	v2.2) with ESMTP id l0A1INIW018065
	for <krb5-bugs at mit.edu>; Tue, 9 Jan 2007 18:18:23 -0700 (MST)
Received: from alton.central.sun.com (localhost [127.0.0.1])
	by alton.central.sun.com (8.13.7+Sun/8.13.7) with ESMTP id
	l0A1INXt028588
	for <krb5-bugs at mit.edu>; Tue, 9 Jan 2007 19:18:23 -0600 (CST)
Received: (from willf at localhost)
	by alton.central.sun.com (8.13.7+Sun/8.13.3/Submit) id l0A1IMuu028578; 
	Tue, 9 Jan 2007 19:18:22 -0600 (CST)
Date: Tue, 9 Jan 2007 19:18:22 -0600 (CST)
Message-Id: <200701100118.l0A1IMuu028578 at alton.central.sun.com>
To: krb5-bugs at mit.edu
Subject: bug in kadmin_unlock()
From: william.fiveash at sun.com
X-send-pr-version: 3.99
X-Spam-Score: 0.55
X-Spam-Flag: NO
X-Scanned-By: MIMEDefang 2.42
X-BeenThere: krb5-bugs-incoming at mailman.mit.edu
X-Mailman-Version: 2.1.6
Precedence: list
Reply-To: william.fiveash at sun.com
Sender: krb5-bugs-incoming-bounces at PCH.mit.edu
Errors-To: krb5-bugs-incoming-bounces at PCH.mit.edu


>Submitter-Id:	net
>Originator:	William Fiveash
>Organization: Sun Microsystems
	
>Confidential:	no 
>Synopsis:	
>Severity:	non-critical 
>Priority:	low 
>Category:	krb5-admin 
>Class:		sw-bug 
>Release:	krb5-1.6
>Environment:
	
System: SunOS alton 5.10 Generic_118833-18 sun4u sparc SUNW,Sun-Blade-1000
Architecture: sun4

>Description:
	
While porting code I noticed this in src/kadmin/cli/kadmin.c:

void kadmin_unlock(argc, argv)
    int argc;
    char *argv[];
{
    kadm5_ret_t retval;

    if (!locked)
        return;
    retval = kadm5_lock(handle);
             !!!!!!!!!! should be kadm5_unlock() no?
    if (retval) {
        com_err("unlock", retval, "");
        return;
    }
    locked = 0;
}

>How-To-Repeat:
	
>Fix:
	
See Description.