[krbdev.mit.edu #3825] CVS Commit

[william.fiveash@sun.com via RT]

I still see in plugins.c:

$ grep 'count.* + sizeof' src/util/support/plugins.c
                newp = realloc (p, ((count + 1) + sizeof (*p))); /* +1 for NULL */

Isn't this a problem also?

On Wed, May 31, 2006 at 08:56:21PM -0400, Ezra Peisach via RT wrote:
> In line 570, in reallocating the plugin tree - the memory allocated is
> (count + 1) + sizeof(*p) 
> 
> instead of 
> 
> (count +1 ) * sizeof(*p)
> 
> Detected while running the krb5kdc under valgrind with memcheck.
> 
> 
> Commit By: epeisach
> 
> 
> 
> Revision: 18070
> Changed Files:
> U   trunk/src/util/support/plugins.c
> 
> _______________________________________________
> krb5-bugs mailing list
> krb5-bugs at mit.edu
> https://mailman.mit.edu/mailman/listinfo/krb5-bugs

-- 
Will Fiveash
Sun Microsystems Inc.
Austin, TX, USA (TZ=CST6CDT)