[krbdev.mit.edu #2910] [Michael Calmer] Patches for MIT Kerberos 1.4

Wed Feb 2 16:18:31 EST 2005

From: Michael Calmer <mc at suse.de>
To: Sam Hartman <hartmans at mit.edu>
Subject: Patches for MIT Kerberos 1.4
Date: Tue, 1 Feb 2005 13:31:48 +0100
User-Agent: KMail/1.7.1
MIME-Version: 1.0
Content-Type: multipart/signed;
  boundary="nextPart1295429.RsZTjP6qv9";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit
Message-Id: <200502011331.53706.mc at suse.de>

--nextPart1295429.RsZTjP6qv9
Content-Type: multipart/mixed;
  boundary="Boundary-01=_1a3/BJz8blBF30P"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

--Boundary-01=_1a3/BJz8blBF30P
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Hi,

my name is Michael Calmer and I am the krb5 package maintainer for SUSE Lin=
ux.

I saw the mail thread "Novell's Work on MIT KDC" where you were included. S=
o I=20
think I can send patches to you.=20

krb5-1.4-gcc4.dif :

 This patch is required to build krb5 with gcc4.


krb5-1.4-reduce-namespace-polution.dif :

 This patch includes only the required "#define" to gssapi.h

 Without this patch we had trouble to build samba, because it was a=20

    #define HAVE_REGEXP_H 1=20

 set. Our samba compiles without regexp but c-files which includes=20
 gssapi.h now have this define and try to use it, but it is not available.

 I think this could happen also with other software.

It would be nice if you can include these patches in krb5. And maybe start =
a=20
discussion about the gssapi.h problem. Maybe you can find an other way=20
instead of the #define(s) :-)

Thanks.

=2D-=20
MFG

	Michael Calmer

=2D-------------------------------------------------------------------------
Michael Calmer
SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 N=C3=BCrnberg
T: +49 (0) 911 74053 0
=46: +49 (0) 911 74053575  - Michael.Calmer at suse.com
=2D-------------------------------------------------------------------------

--Boundary-01=_1a3/BJz8blBF30P
Content-Type: text/x-diff;
  charset="utf-8";
  name="krb5-1.4-gcc4.dif"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
	filename="krb5-1.4-gcc4.dif"

=2D-- src/appl/bsd/krlogind.c
+++ src/appl/bsd/krlogind.c	2005/01/28 11:51:50
@@ -833,12 +833,12 @@
         fatalperror(f, "failed make_sane_hostname");
     if (passwd_req)
         execl(login_program, "login", "-p", "-h", rhost_sane,
=2D          lusername, 0);
+          lusername, (char*)NULL);
     else
         execl(login_program, "login", "-p", "-h", rhost_sane,
=2D             "-f", lusername, 0);
+             "-f", lusername, (char*)NULL);
 #else /* USE_LOGIN_F */
=2D	execl(login_program, "login", "-r", rhost_sane, 0);
+	execl(login_program, "login", "-r", rhost_sane, (char*)NULL);
 #endif /* USE_LOGIN_F */
 	syslog(LOG_ERR, "failed exec of %s: %s",
 	       login_program, error_message(errno));
=2D-- src/appl/bsd/krshd.c
+++ src/appl/bsd/krshd.c	2005/01/28 11:49:08
@@ -1521,10 +1521,10 @@
       cp =3D pwd->pw_shell;
    =20
     if (do_encrypt && !strncmp(cmdbuf, "-x ", 3)) {
=2D	execl(pwd->pw_shell, cp, "-c", (char *)cmdbuf + 3, 0);
+	execl(pwd->pw_shell, cp, "-c", (char *)cmdbuf + 3, (char*)NULL);
     }
     else {
=2D	execl(pwd->pw_shell, cp, "-c", cmdbuf, 0);
+	execl(pwd->pw_shell, cp, "-c", cmdbuf, (char*)NULL);
     }
     perror(pwd->pw_shell);
     perror(cp);
=2D-- src/appl/bsd/login.c
+++ src/appl/bsd/login.c	2005/01/28 11:52:31
@@ -1861,7 +1861,7 @@
     (void) strncpy(tbuf+1, p?(p+1):pwd->pw_shell, sizeof(tbuf) - 1);
     tbuf[sizeof(tbuf) - 1] =3D '\0';
=20
=2D    execlp(pwd->pw_shell, tbuf, 0);
+    execlp(pwd->pw_shell, tbuf, (char*)NULL);
     fprintf(stderr, "login: no shell: ");
     perror(pwd->pw_shell);
     exit(0);
=2D-- src/appl/telnet/telnet/commands.c
+++ src/appl/telnet/telnet/commands.c	2005/01/28 11:50:17
@@ -1467,9 +1467,9 @@
 	    else
 		shellname++;
 	    if (argc > 1)
=2D		execl(shellp, shellname, "-c", &saveline[1], 0);
+		execl(shellp, shellname, "-c", &saveline[1], (char*)NULL);
 	    else
=2D		execl(shellp, shellname, 0);
+		execl(shellp, shellname, (char*)NULL);
 	    perror("Execl");
 	    _exit(1);
 	}

--Boundary-01=_1a3/BJz8blBF30P
Content-Type: text/x-diff;
  charset="utf-8";
  name="krb5-1.4-reduce-namespace-polution.dif"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="krb5-1.4-reduce-namespace-polution.dif"

--- src/lib/gssapi/generic/Makefile.in
+++ src/lib/gssapi/generic/Makefile.in	2005/02/01 10:48:04
@@ -42,9 +42,11 @@
 	h=gss$$$$; $(RM) $$h; \
 	(echo "/* This is the gssapi.h prologue. */"; \
 	echo "/* It contains some choice pieces of autoconf.h */"; \
-	grep SIZEOF $(BUILDTOP)/include/krb5/autoconf.h; \
-	grep 'HAVE_.*_H' $(BUILDTOP)/include/krb5/autoconf.h; \
-	grep 'USE_.*_H' $(BUILDTOP)/include/krb5/autoconf.h; \
+	grep SIZEOF_INT $(BUILDTOP)/include/krb5/autoconf.h; \
+	grep SIZEOF_LONG $(BUILDTOP)/include/krb5/autoconf.h; \
+	grep SIZEOF_SHORT $(BUILDTOP)/include/krb5/autoconf.h; \
+	grep HAVE_STDDEF_H $(BUILDTOP)/include/krb5/autoconf.h; \
+	grep HAVE_XOM_H $(BUILDTOP)/include/krb5/autoconf.h; \
 	echo "/* End of gssapi.h prologue. */"; \
 	cat $(srcdir)/gssapi.hin )> $$h && \
 	(set -x; $(MV) $$h $@) ; e=$$?; $(RM) $$h; exit $$e

--Boundary-01=_1a3/BJz8blBF30P--

--nextPart1295429.RsZTjP6qv9
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQBB/3a5rQn+SxpBP/IRAn9sAJ9g9LSfnVS64Dwr3rB4Ph/j9y9x9ACgqy1z
u2X+3XDY1GNovNXrihV36Ig=
=Db0d
-----END PGP SIGNATURE-----

--nextPart1295429.RsZTjP6qv9--


