[krbdev.mit.edu #3313] doublefree in gc_frm_kdc.c

Tom Yu via RT rt-comment at krbdev.mit.edu
Tue Dec 27 20:52:06 EST 2005


[Line numbers refer to file after application of Jeff's patch.]

The extra call to free_cred_contents() at line 164 will never be
executed, as there is no way for free_tgt to be 1 at that point.
Otherwise, it appears to be functionally nearly identical to my
patch.  Jeff, were there any cases your patch covers which mine does
not?  I didn't think there were, but I wanted to make sure I wasn't
missing something.

This file badly needs rewriting.  (I've got a rewrite in progress.)

---Tom




More information about the krb5-bugs mailing list