[krbdev.mit.edu #7989] git commit

Benjamin Kaduk via RT rt at krbdev.mit.edu
Tue Sep 9 17:37:08 EDT 2014



Remove old Windows support from cc_mslsa.c

It is safe to remove is_windows_2000(), is_windows_xp(), and
is_windows_vista(), since the former two only check for very old
versions of windows which are no longer supported, and
is_windows_vista() was unused.  Note that the check being implemented
was whether the running OS was the named version or higher, not an
exact match.  The current Microsoft documentation recommends against
the sort of OS version checks that were employed here, in favor of
explicit feature tests.

Remove is_broken_wow64() as the problem it works around (Microsoft
Article ID 960077) is believed to have been fixed in subsequent
updates to Windows Server 2003 and XP.

Remove does_retrieve_ticket_cache_ticket() since support for the
KERB_RETRIEVE_TICKET_CACHE_TICKET flag in the
KERB_RETRIEVE_TKT_REQUEST structure was added in service packs for
Windows Server 2003 and XP.  Also remove buildtime fallbacks that
are no longer needed.

Remove the conditionals TRUST_ATTRIBUTE_TRUST_USES_AES_KEYS,
HAVE_CACHE_INFO_EX2, and KERB_SUBMIT_TICKET as all current SDK
versions have the relevant functionality.

In all cases, de-indent chunks that are no longer conditional.
Where indentation levels changed, update the style of the reindented
code to current practices.

https://github.com/krb5/krb5/commit/471b8474de8c5dfbbcc6a5a39201426bdca09f0d
Author: Ben Kaduk <kaduk at mit.edu>
Commit: 471b8474de8c5dfbbcc6a5a39201426bdca09f0d
Branch: master
 src/lib/krb5/ccache/cc_mslsa.c |  603 +++++-----------------------------------
 1 files changed, 66 insertions(+), 537 deletions(-)


More information about the kfwdev mailing list