Module Name:	krb5
Committed By:	raeburn
Date:		Wed Feb 23 22:47:14 UTC 2005

Modified Files:
	 krb5/src/util/profile/ChangeLog krb5/src/util/profile/prof_file.c
		krb5/src/util/profile/prof_int.h
		krb5/src/util/profile/prof_tree.c
Added Files:

Removed Files:


Log Message
ticket: new
subject: possible profile null pointer deref in threaded app
status: open

There seems to be a problem with a null pointer popping up when
profile_node_iterator reads ...->data->root to start walking through the
contents.  Don't have a lot of details, but I've got some patches that might
tighten things up a little.

* prof_tree.c (profile_node_iterator): Check that the root node pointer is not
null; raise assertion failure if it is.

* prof_int.h: Include k5-platform.h.
(struct _prf_data_t): Reorder fields, and insert some padding.

* prof_file.c (scan_shared_trees_locked): Check that the "root" field isn't
null.
(profile_open_file): Update the in-memory file contents after updating the
refcount instead of before.
(profile_update_file_data): If the root node in the file data is null, always
do the update.  Check that it's not null before returning a success
indication.
(profile_dereference_data_locked): Scan linked list of file data objects for
sanity check, before and after.
(profile_dereference_data_locked): Don't do it here.


To generate a diff of this commit:
	cvs diff -r1.175 -r1.176 krb5/src/util/profile/ChangeLog
	cvs diff -r1.51 -r1.52 krb5/src/util/profile/prof_file.c
	cvs diff -r1.41 -r1.42 krb5/src/util/profile/prof_int.h
	cvs diff -r1.28 -r1.29 krb5/src/util/profile/prof_tree.c