krb5 commit [krb5-1.14]: Fix leaks in gss_inquire_cred_by_oid()

Greg Hudson ghudson at mit.edu
Mon Jul 17 22:41:19 EDT 2017


https://github.com/krb5/krb5/commit/08d2e1baba285382a2d953b0e18314143796ac0b
commit 08d2e1baba285382a2d953b0e18314143796ac0b
Author: Greg Hudson <ghudson at mit.edu>
Date:   Sun Mar 12 12:30:59 2017 -0400

    Fix leaks in gss_inquire_cred_by_oid()
    
    In the mechglue gss_inquire_cred_by_oid(), remove an unnecessary
    allocation of ret_set which is overwritten by the first mechanism's
    result.
    
    (cherry picked from commit 0d39d46852587d36fcc5024d5766586faba9044a)
    
    ticket: 8559
    version_fixed: 1.14.6

 src/lib/gssapi/mechglue/g_inq_cred_oid.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/src/lib/gssapi/mechglue/g_inq_cred_oid.c b/src/lib/gssapi/mechglue/g_inq_cred_oid.c
index 4c23dfc..df51b44 100644
--- a/src/lib/gssapi/mechglue/g_inq_cred_oid.c
+++ b/src/lib/gssapi/mechglue/g_inq_cred_oid.c
@@ -85,11 +85,6 @@ gss_inquire_cred_by_oid(OM_uint32 *minor_status,
 
     union_cred = (gss_union_cred_t) cred_handle;
 
-    status = gss_create_empty_buffer_set(minor_status, &ret_set);
-    if (status != GSS_S_COMPLETE) {
-	return status;
-    }
-
     status = GSS_S_UNAVAILABLE;
 
     for (i = 0; i < union_cred->count; i++) {


More information about the cvs-krb5 mailing list