krb5 commit: Fix mismatched sign comparisons

Greg Hudson ghudson at mit.edu
Fri Apr 14 12:14:34 EDT 2017


https://github.com/krb5/krb5/commit/491ea55c12b5139f181756f606b579f6ed088ac9
commit 491ea55c12b5139f181756f606b579f6ed088ac9
Author: Robbie Harwood <rharwood at redhat.com>
Date:   Thu Feb 16 18:02:09 2017 -0500

    Fix mismatched sign comparisons

 src/lib/gssapi/krb5/k5unseal.c        |    2 +-
 src/lib/kadm5/unit-test/setkey-test.c |    3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/lib/gssapi/krb5/k5unseal.c b/src/lib/gssapi/krb5/k5unseal.c
index 26a2d33..57720c2 100644
--- a/src/lib/gssapi/krb5/k5unseal.c
+++ b/src/lib/gssapi/krb5/k5unseal.c
@@ -219,7 +219,7 @@ kg_unseal_v1(context, minor_status, ctx, ptr, bodysize, message_buffer,
         plainlen = tmsglen;
 
         conflen = kg_confounder_size(context, ctx->enc->keyblock.enctype);
-        if (tmsglen < conflen) {
+        if (tmsglen < (size_t)conflen) {
             if (sealalg != 0xffff)
                 xfree(plain);
             *minor_status = 0;
diff --git a/src/lib/kadm5/unit-test/setkey-test.c b/src/lib/kadm5/unit-test/setkey-test.c
index 60be9e8..0431653 100644
--- a/src/lib/kadm5/unit-test/setkey-test.c
+++ b/src/lib/kadm5/unit-test/setkey-test.c
@@ -69,7 +69,8 @@ main(int argc, char **argv)
     char *whoami, *principal, *authprinc, *authpwd;
     krb5_data pwdata;
     void *handle;
-    int ret, i, test, encnum;
+    int ret, test, encnum;
+    unsigned int i;
 
     whoami = argv[0];
 


More information about the cvs-krb5 mailing list