krb5 commit: Error on discarded qualifiers in gcc

Greg Hudson ghudson at mit.edu
Thu Oct 6 11:15:24 EDT 2016


https://github.com/krb5/krb5/commit/993c7c313366f3bcb86b695d6d3b0355fbc53d3f
commit 993c7c313366f3bcb86b695d6d3b0355fbc53d3f
Author: Greg Hudson <ghudson at mit.edu>
Date:   Tue Oct 4 12:36:30 2016 -0400

    Error on discarded qualifiers in gcc
    
    If a function call passes a const pointer to a function accepting the
    same pointer type without the const qualifier, that should be treated
    as an erorr if possible.  In sufficiently recent gcc, pass
    -Werror=discarded-qualifiers.  (In clang, this is already covered by
    -Werror=incompatible-pointer-types which we recently added.)

 src/aclocal.m4 |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/aclocal.m4 b/src/aclocal.m4
index b9f9d2a..bd2eb48 100644
--- a/src/aclocal.m4
+++ b/src/aclocal.m4
@@ -526,7 +526,7 @@ if test "$GCC" = yes ; then
     TRY_WARN_CC_FLAG(-Wno-format-zero-length)
     # Other flags here may not be supported on some versions of
     # gcc that people want to use.
-    for flag in overflow strict-overflow missing-format-attribute missing-prototypes return-type missing-braces parentheses switch unused-function unused-label unused-variable unused-value unknown-pragmas sign-compare newline-eof error=uninitialized error=pointer-arith error=int-conversion error=incompatible-pointer-types ; do
+    for flag in overflow strict-overflow missing-format-attribute missing-prototypes return-type missing-braces parentheses switch unused-function unused-label unused-variable unused-value unknown-pragmas sign-compare newline-eof error=uninitialized error=pointer-arith error=int-conversion error=incompatible-pointer-types error=discarded-qualifiers ; do
       TRY_WARN_CC_FLAG(-W$flag)
     done
     #  old-style-definition? generates many, many warnings


More information about the cvs-krb5 mailing list