krb5 commit [krb5-1.12]: Log invalid restrictions strings

Tom Yu tlyu at mit.edu
Tue May 12 15:46:07 EDT 2015


https://github.com/krb5/krb5/commit/16757adc05ecc9605f306b7b0c3147ae09133cd3
commit 16757adc05ecc9605f306b7b0c3147ae09133cd3
Author: Greg Hudson <ghudson at mit.edu>
Date:   Fri Mar 13 13:30:49 2015 -0400

    Log invalid restrictions strings
    
    In kadm5int_acl_parse_restrictions(), output a log message if we break
    out of the parsing loop with an error.  The current structure of the
    loop makes it difficult to pinpoint the bad restrictions field, so
    just output the whole string.
    
    (cherry picked from commit e9eaafeab12b2b62595f4dff2fca3345b2d95b4a)
    (cherry picked from commit 1ff2ecc7890ae4b843c77c2ba68f5a152806bf05)
    
    ticket: 8185 (new)
    version_fixed: 1.12.4
    status: resolved

 src/lib/kadm5/srv/server_acl.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/src/lib/kadm5/srv/server_acl.c b/src/lib/kadm5/srv/server_acl.c
index 9d971a9..5021f5b 100644
--- a/src/lib/kadm5/srv/server_acl.c
+++ b/src/lib/kadm5/srv/server_acl.c
@@ -350,6 +350,10 @@ kadm5int_acl_parse_restrictions(s, rpp)
                     }
                 }
             }
+            if (code) {
+                krb5_klog_syslog(LOG_ERR, _("%s: invalid restrictions: %s"),
+                                 acl_acl_file, s);
+            }
         }
     }
     if (sp)


More information about the cvs-krb5 mailing list