krb5 commit [krb5-1.10]: Ensure null termination of AFS salts

Tom Yu tlyu at MIT.EDU
Fri Jan 11 14:50:27 EST 2013


https://github.com/krb5/krb5/commit/a79e78cdcfa70d48a9357bbe16a3323b899c8219
commit a79e78cdcfa70d48a9357bbe16a3323b899c8219
Author: Greg Hudson <ghudson at mit.edu>
Date:   Fri Apr 27 17:04:24 2012 +0000

    Ensure null termination of AFS salts
    
    Use krb5int_copy_data_contents_add0 when copying a pa-pw-salt or
    pa-afs3-salt value in pa_salt().  If it's an afs3-salt, we're going to
    throw away the length and use strcspn in krb5int_des_string_to_key,
    which isn't safe if the value is unterminated.
    
    (cherry picked from commit f566fee75f2455d6e5e7ee4fcdf5a0d327808639)
    
    ticket: 7537 (new)
    version_fixed: 1.10.4
    status: resolved

 src/lib/krb5/krb/preauth2.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/lib/krb5/krb/preauth2.c b/src/lib/krb5/krb/preauth2.c
index d43c20e..625ee4d 100644
--- a/src/lib/krb5/krb/preauth2.c
+++ b/src/lib/krb5/krb/preauth2.c
@@ -548,7 +548,7 @@ pa_salt(krb5_context context, krb5_kdc_req *request, krb5_pa_data *in_padata,
 
     tmp = padata2data(*in_padata);
     krb5_free_data_contents(context, salt);
-    retval = krb5int_copy_data_contents(context, &tmp, salt);
+    retval = krb5int_copy_data_contents_add0(context, &tmp, salt);
     if (retval)
         return retval;
 


More information about the cvs-krb5 mailing list