svn rev #22172: trunk/src/util/ss/

epeisach@MIT.EDU epeisach at MIT.EDU
Tue Apr 7 13:57:57 EDT 2009


http://src.mit.edu/fisheye/changelog/krb5/?cs=22172
Commit By: epeisach
Log Message:
ticket: 6442
subject: Null pointer defref in adding info

Clearly the code is broken - and we either never use it - or callers never pass
NULL...

Detected by clang static checker.




Changed Files:
U   trunk/src/util/ss/help.c
Modified: trunk/src/util/ss/help.c
===================================================================
--- trunk/src/util/ss/help.c	2009-04-05 21:11:26 UTC (rev 22171)
+++ trunk/src/util/ss/help.c	2009-04-07 17:57:56 UTC (rev 22172)
@@ -107,7 +107,7 @@
     register char **dirs;
 
     info = ss_info(sci_idx);
-    if (info_dir == NULL && *info_dir) {
+    if ((info_dir == NULL) || (*info_dir == '\0')) {
 	*code_ptr = SS_ET_NO_INFO_DIR;
 	return;
     }




More information about the cvs-krb5 mailing list