From raeburn at MIT.EDU Sat Aug 2 00:28:21 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Sat, 2 Aug 2008 00:28:21 -0400 (EDT) Subject: svn rev #20593: trunk/src/lib/krb5/krb/ Message-ID: <200808020428.AAA14626@drugstore.mit.edu> Commit By: raeburn Log Message: Pull out code to compute length of quoted name component and copy with quoting into separate functions, to reduce code duplication. Changed Files: U trunk/src/lib/krb5/krb/unparse.c From raeburn at MIT.EDU Sat Aug 2 01:17:55 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Sat, 2 Aug 2008 01:17:55 -0400 (EDT) Subject: svn rev #20594: trunk/src/lib/krb5/keytab/ Message-ID: <200808020517.BAA15247@drugstore.mit.edu> Commit By: raeburn Log Message: Two versions of resolver code were almost identical, so unify them and reduce duplication.. Changed Files: U trunk/src/lib/krb5/keytab/kt_file.c From raeburn at MIT.EDU Sat Aug 2 02:12:09 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Sat, 2 Aug 2008 02:12:09 -0400 (EDT) Subject: svn rev #20595: trunk/src/lib/krb5/ccache/ Message-ID: <200808020612.CAA15861@drugstore.mit.edu> Commit By: raeburn Log Message: Reduce code duplication: krb5_fcc_store_int32 vs krb5_fcc_store_ui_4. Changed Files: U trunk/src/lib/krb5/ccache/cc_file.c From raeburn at MIT.EDU Sat Aug 2 02:21:10 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Sat, 2 Aug 2008 02:21:10 -0400 (EDT) Subject: svn rev #20596: trunk/src/ include/ lib/krb5/ccache/ Message-ID: <200808020621.CAA16030@drugstore.mit.edu> Commit By: raeburn Log Message: Rename and export random_string from cc_memory.c. Changed Files: U trunk/src/include/k5-int.h U trunk/src/lib/krb5/ccache/cc_memory.c From raeburn at MIT.EDU Sat Aug 2 02:24:56 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Sat, 2 Aug 2008 02:24:56 -0400 (EDT) Subject: svn rev #20597: trunk/src/lib/krb5/ccache/ Message-ID: <200808020624.CAA16154@drugstore.mit.edu> Commit By: raeburn Log Message: Use krb5int_random_string, load_32_be, load_16_be, store_32_be, and store_16_be. Change krb5_krcc_unparse_int32 to call krb5_krc_unparse_ui_4 and reduce duplicated code. Changed Files: U trunk/src/lib/krb5/ccache/cc_keyring.c From raeburn at MIT.EDU Sat Aug 2 02:34:52 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Sat, 2 Aug 2008 02:34:52 -0400 (EDT) Subject: svn rev #20598: trunk/src/lib/crypto/des/ Message-ID: <200808020634.CAA16356@drugstore.mit.edu> Commit By: raeburn Log Message: Use GET_HALF_BLOCK to fetch new values instead of open-coding. Changed Files: U trunk/src/lib/crypto/des/d3_cbc.c U trunk/src/lib/crypto/des/f_cksum.c From raeburn at MIT.EDU Sat Aug 2 02:36:50 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Sat, 2 Aug 2008 02:36:50 -0400 (EDT) Subject: svn rev #20599: trunk/src/lib/crypto/ aes/ arcfour/ des/ md4/ md5/ sha1/ Message-ID: <200808020636.CAA16468@drugstore.mit.edu> Commit By: raeburn Log Message: Make more uses of load/store_32_be/le, which on x86 at least expands to a single unaligned load/store instruction, instead of open-coding the shifts and masks. Changed Files: U trunk/src/lib/crypto/aes/aes_s2k.c U trunk/src/lib/crypto/arcfour/arcfour.c U trunk/src/lib/crypto/des/f_sched.c U trunk/src/lib/crypto/md4/md4.c U trunk/src/lib/crypto/md5/md5.c U trunk/src/lib/crypto/pbkdf2.c U trunk/src/lib/crypto/sha1/shs.c From raeburn at MIT.EDU Sat Aug 2 02:39:29 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Sat, 2 Aug 2008 02:39:29 -0400 (EDT) Subject: svn rev #20600: trunk/src/util/profile/ Message-ID: <200808020639.CAA16567@drugstore.mit.edu> Commit By: raeburn Log Message: Use load/store_32_be instead of open-coding. Changed Files: U trunk/src/util/profile/prof_init.c From raeburn at MIT.EDU Sat Aug 2 02:44:09 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Sat, 2 Aug 2008 02:44:09 -0400 (EDT) Subject: svn rev #20601: trunk/src/lib/gssapi/ krb5/ mechglue/ Message-ID: <200808020644.CAA16699@drugstore.mit.edu> Commit By: raeburn Log Message: Use load_store_16/32_be. Changed Files: U trunk/src/lib/gssapi/krb5/export_name.c U trunk/src/lib/gssapi/mechglue/g_imp_name.c From raeburn at MIT.EDU Sat Aug 2 02:46:18 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Sat, 2 Aug 2008 02:46:18 -0400 (EDT) Subject: svn rev #20602: trunk/src/lib/krb5/rcache/ Message-ID: <200808020646.CAA16815@drugstore.mit.edu> Commit By: raeburn Log Message: Pull out two copies of errno mapping into a common function. Changed Files: U trunk/src/lib/krb5/rcache/rc_io.c From raeburn at MIT.EDU Sat Aug 2 02:47:34 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Sat, 2 Aug 2008 02:47:34 -0400 (EDT) Subject: svn rev #20603: trunk/src/lib/krb5/ krb/ os/ Message-ID: <200808020647.CAA16904@drugstore.mit.edu> Commit By: raeburn Log Message: Use load/store_32/16_be/le functions. Changed Files: U trunk/src/lib/krb5/krb/serialize.c U trunk/src/lib/krb5/os/mk_faddr.c U trunk/src/lib/krb5/os/sendto_kdc.c From raeburn at MIT.EDU Mon Aug 4 17:39:11 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Mon, 4 Aug 2008 17:39:11 -0400 (EDT) Subject: svn rev #20604: trunk/doc/ Message-ID: <200808042139.RAA29869@drugstore.mit.edu> Commit By: raeburn Log Message: some comments from Love Changed Files: U trunk/doc/iprop-notes.txt From raeburn at MIT.EDU Tue Aug 5 16:52:58 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Tue, 5 Aug 2008 16:52:58 -0400 (EDT) Subject: svn rev #20605: trunk/src/lib/rpc/ Message-ID: <200808052052.QAA14970@drugstore.mit.edu> Commit By: raeburn Log Message: specify return type of 'harmless' Changed Files: U trunk/src/lib/rpc/xdr_sizeof.c From raeburn at MIT.EDU Tue Aug 5 18:15:34 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Tue, 5 Aug 2008 18:15:34 -0400 (EDT) Subject: svn rev #20606: trunk/src/kdc/ Message-ID: <200808052215.SAA15618@drugstore.mit.edu> Commit By: raeburn Log Message: ticket: new subject: error in socket number range check in kdc target_version: 1.6.4 tags: pullup Fix off-by-one error in checking that socket file descriptor numbers are in range suitable for an fd_set. Also, don't do the check if we should someday happen to get compiled on Windows. Changed Files: U trunk/src/kdc/network.c From raeburn at MIT.EDU Tue Aug 5 20:01:38 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Tue, 5 Aug 2008 20:01:38 -0400 (EDT) Subject: svn rev #20607: trunk/src/tests/gss-threads/ Message-ID: <200808060001.UAA16384@drugstore.mit.edu> Commit By: raeburn Log Message: Fix possible locking protocol failure in error handling path. Changed Files: U trunk/src/tests/gss-threads/gss-client.c U trunk/src/tests/gss-threads/gss-server.c From raeburn at MIT.EDU Tue Aug 5 20:05:47 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Tue, 5 Aug 2008 20:05:47 -0400 (EDT) Subject: svn rev #20608: trunk/src/lib/krb5/krb/ Message-ID: <200808060005.UAA16506@drugstore.mit.edu> Commit By: raeburn Log Message: ticket: new subject: fix cleanup code in allocating preauth info target_version: 1.6.4 tags: pullup After an allocation failure, free up the previously allocated array elements by counting back down to zero, not continuing to count up until we hit zero. Changed Files: U trunk/src/lib/krb5/krb/get_in_tkt.c From raeburn at MIT.EDU Tue Aug 5 20:10:43 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Tue, 5 Aug 2008 20:10:43 -0400 (EDT) Subject: svn rev #20609: trunk/src/util/profile/ Message-ID: <200808060010.UAA16621@drugstore.mit.edu> Commit By: raeburn Log Message: Always use unsigned for one-bit fields. Changed Files: U trunk/src/util/profile/prof_tree.c From raeburn at MIT.EDU Wed Aug 6 11:47:25 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 6 Aug 2008 11:47:25 -0400 (EDT) Subject: svn rev #20610: trunk/src/util/ss/ Message-ID: <200808061547.LAA24209@drugstore.mit.edu> Commit By: raeburn Log Message: Fix bug in array size calculation. Changed Files: U trunk/src/util/ss/request_tbl.c From raeburn at MIT.EDU Wed Aug 6 11:51:49 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 6 Aug 2008 11:51:49 -0400 (EDT) Subject: svn rev #20611: trunk/src/slave/ Message-ID: <200808061551.LAA24422@drugstore.mit.edu> Commit By: raeburn Log Message: ticket: new subject: bad free in kprop target_version: 1.6.4 tags: pullup Don't free automatic storage after sending database. Changed Files: U trunk/src/slave/kprop.c From raeburn at MIT.EDU Wed Aug 6 11:54:45 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 6 Aug 2008 11:54:45 -0400 (EDT) Subject: svn rev #20612: trunk/src/appl/bsd/ Message-ID: <200808061554.LAA24589@drugstore.mit.edu> Commit By: raeburn Log Message: Fix test for accept failure. Changed Files: U trunk/src/appl/bsd/krlogind.c From raeburn at MIT.EDU Wed Aug 6 11:55:10 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 6 Aug 2008 11:55:10 -0400 (EDT) Subject: svn rev #20613: trunk/src/appl/gssftp/ftp/ Message-ID: <200808061555.LAA24707@drugstore.mit.edu> Commit By: raeburn Log Message: cstatus() takes no arguments. Changed Files: U trunk/src/appl/gssftp/ftp/cmds.c From raeburn at MIT.EDU Wed Aug 6 12:19:56 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 6 Aug 2008 12:19:56 -0400 (EDT) Subject: svn rev #20614: trunk/src/kadmin/dbutil/ Message-ID: <200808061619.MAA24955@drugstore.mit.edu> Commit By: raeburn Log Message: Removed unused (and unpassed) argument to process_k5beta7_policy. Changed Files: U trunk/src/kadmin/dbutil/dump.c From raeburn at MIT.EDU Wed Aug 6 12:41:51 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 6 Aug 2008 12:41:51 -0400 (EDT) Subject: svn rev #20615: trunk/src/kadmin/server/ Message-ID: <200808061641.MAA25248@drugstore.mit.edu> Commit By: raeburn Log Message: Check for malloc failure. Changed Files: U trunk/src/kadmin/server/schpw.c From raeburn at MIT.EDU Wed Aug 6 12:43:05 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 6 Aug 2008 12:43:05 -0400 (EDT) Subject: svn rev #20616: trunk/src/lib/kadm5/srv/ Message-ID: <200808061643.MAA25343@drugstore.mit.edu> Commit By: raeburn Log Message: Don't coerce fgetc value to char before EOF check. Changed Files: U trunk/src/lib/kadm5/srv/server_acl.c From raeburn at MIT.EDU Wed Aug 6 12:43:44 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 6 Aug 2008 12:43:44 -0400 (EDT) Subject: svn rev #20617: trunk/src/lib/kadm5/clnt/ Message-ID: <200808061643.MAA25432@drugstore.mit.edu> Commit By: raeburn Log Message: Fully initialize handle data on allocation. Changed Files: U trunk/src/lib/kadm5/clnt/client_init.c From raeburn at MIT.EDU Wed Aug 6 12:46:26 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 6 Aug 2008 12:46:26 -0400 (EDT) Subject: svn rev #20618: trunk/src/lib/kdb/ Message-ID: <200808061646.MAA25544@drugstore.mit.edu> Commit By: raeburn Log Message: In loop over entries, make local vars local to each iteration. Changed Files: U trunk/src/lib/kdb/kdb_convert.c From raeburn at MIT.EDU Wed Aug 6 12:46:53 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 6 Aug 2008 12:46:53 -0400 (EDT) Subject: svn rev #20619: trunk/src/lib/kdb/ Message-ID: <200808061646.MAA25633@drugstore.mit.edu> Commit By: raeburn Log Message: After freeing dbprinc, reset it to null. Changed Files: U trunk/src/lib/kdb/kdb_log.c From raeburn at MIT.EDU Wed Aug 6 12:47:39 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 6 Aug 2008 12:47:39 -0400 (EDT) Subject: svn rev #20620: trunk/src/lib/kdb/ Message-ID: <200808061647.MAA25722@drugstore.mit.edu> Commit By: raeburn Log Message: Rewrite conditional test for update log processing to make static analysis simpler. Changed Files: U trunk/src/lib/kdb/kdb5.c From raeburn at MIT.EDU Wed Aug 6 13:28:52 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 6 Aug 2008 13:28:52 -0400 (EDT) Subject: svn rev #20621: trunk/src/lib/des425/ Message-ID: <200808061728.NAA26139@drugstore.mit.edu> Commit By: raeburn Log Message: Remove some 'register' declarations. Changed Files: U trunk/src/lib/des425/pcbc_encrypt.c From raeburn at MIT.EDU Wed Aug 6 13:33:32 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 6 Aug 2008 13:33:32 -0400 (EDT) Subject: svn rev #20622: trunk/src/kadmin/dbutil/ Message-ID: <200808061733.NAA26263@drugstore.mit.edu> Commit By: raeburn Log Message: Oops. Really delete the extra argument this time. Changed Files: U trunk/src/kadmin/dbutil/dump.c From raeburn at MIT.EDU Wed Aug 6 14:16:38 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 6 Aug 2008 14:16:38 -0400 (EDT) Subject: svn rev #20623: trunk/src/ include/ util/support/ Message-ID: <200808061816.OAA26697@drugstore.mit.edu> Commit By: raeburn Log Message: If CONFIG_SMALL is defined, always use function calls for k5_mutex_lock and _unlock. On ppc darwin builds with debug info, this makes lib*.dylib a total of about 46K (~3%) smaller; "size" reports a reduction in text and/or "other" sizes for libgssapi_krb5, libkdb5, libkdb_ldap, and libkrb5. Changed Files: U trunk/src/include/k5-thread.h U trunk/src/util/support/threads.c From raeburn at MIT.EDU Wed Aug 6 14:47:06 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 6 Aug 2008 14:47:06 -0400 (EDT) Subject: svn rev #20624: trunk/src/lib/kdb/ Message-ID: <200808061847.OAA26992@drugstore.mit.edu> Commit By: raeburn Log Message: Check fstat result. Close fd on error. Changed Files: U trunk/src/lib/kdb/kdb_log.c From raeburn at MIT.EDU Wed Aug 6 18:12:17 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 6 Aug 2008 18:12:17 -0400 (EDT) Subject: svn rev #20625: trunk/src/include/ Message-ID: <200808062212.SAA28715@drugstore.mit.edu> Commit By: raeburn Log Message: ticket: new subject: turn off thread-support debugging code With one big known exception having to do with exiting processes, I think we've shaken out most of the thread-related bugs that this code is going to catch in the existing code. It adds a lot of runtime code, so disable it for now, it can be enabled again for testing new changes. Changed Files: U trunk/src/include/k5-thread.h From raeburn at MIT.EDU Wed Aug 6 20:14:01 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 6 Aug 2008 20:14:01 -0400 (EDT) Subject: svn rev #20626: trunk/src/lib/krb5/asn.1/ Message-ID: <200808070014.UAA29779@drugstore.mit.edu> Commit By: raeburn Log Message: Rewrite tagnum-checking code to streamline normal path and push refined error code selection into error path. Don't expand asn1buf_insert_octet inline or define asn1buf_ensure_space macro if CONFIG_SMALL. Remove some null-before-free checks. Changed Files: U trunk/src/lib/krb5/asn.1/asn1_k_decode.c U trunk/src/lib/krb5/asn.1/asn1buf.c U trunk/src/lib/krb5/asn.1/asn1buf.h U trunk/src/lib/krb5/asn.1/krb5_decode.c U trunk/src/lib/krb5/asn.1/ldap_key_seq.c From wfiveash at MIT.EDU Wed Aug 6 20:22:38 2008 From: wfiveash at MIT.EDU (wfiveash@MIT.EDU) Date: Wed, 6 Aug 2008 20:22:38 -0400 (EDT) Subject: svn rev #20627: branches/mkey_keytab/src/ tests/ tests/mkeystash_compat/ Message-ID: <200808070022.UAA29958@drugstore.mit.edu> Commit By: wfiveash Log Message: Add test case to test that new mkey stash code is backward compat with old format stash file. Changed Files: U branches/mkey_keytab/src/configure.in U branches/mkey_keytab/src/tests/Makefile.in A branches/mkey_keytab/src/tests/mkeystash_compat/ A branches/mkey_keytab/src/tests/mkeystash_compat/Makefile.in A branches/mkey_keytab/src/tests/mkeystash_compat/bigendian.c A branches/mkey_keytab/src/tests/mkeystash_compat/old_stash_bendian A branches/mkey_keytab/src/tests/mkeystash_compat/old_stash_lendian From raeburn at MIT.EDU Wed Aug 6 20:46:47 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 6 Aug 2008 20:46:47 -0400 (EDT) Subject: svn rev #20628: trunk/src/lib/krb5/asn.1/ Message-ID: <200808070046.UAA00205@drugstore.mit.edu> Commit By: raeburn Log Message: Use bitfields for class and construction type. Changed Files: U trunk/src/lib/krb5/asn.1/asn1_get.h From raeburn at MIT.EDU Wed Aug 6 20:59:30 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 6 Aug 2008 20:59:30 -0400 (EDT) Subject: svn rev #20629: trunk/src/lib/krb5/asn.1/ Message-ID: <200808070059.UAA00376@drugstore.mit.edu> Commit By: raeburn Log Message: Pull out EOC error checks into separate functions. Changed Files: U trunk/src/lib/krb5/asn.1/asn1_k_decode.c U trunk/src/lib/krb5/asn.1/krb5_decode.c From raeburn at MIT.EDU Wed Aug 6 21:23:35 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 6 Aug 2008 21:23:35 -0400 (EDT) Subject: svn rev #20630: trunk/src/lib/krb5/ krb/ os/ rcache/ Message-ID: <200808070123.VAA00606@drugstore.mit.edu> Commit By: raeburn Log Message: malloc+memset(,0,) -> calloc Changed Files: U trunk/src/lib/krb5/krb/auth_con.c U trunk/src/lib/krb5/krb/gc_via_tkt.c U trunk/src/lib/krb5/krb/init_ctx.c U trunk/src/lib/krb5/krb/mk_cred.c U trunk/src/lib/krb5/krb/pkinit_apple_asn1.c U trunk/src/lib/krb5/krb/preauth2.c U trunk/src/lib/krb5/krb/rd_cred.c U trunk/src/lib/krb5/krb/ser_actx.c U trunk/src/lib/krb5/krb/ser_adata.c U trunk/src/lib/krb5/krb/ser_addr.c U trunk/src/lib/krb5/krb/ser_auth.c U trunk/src/lib/krb5/krb/ser_cksum.c U trunk/src/lib/krb5/krb/ser_ctx.c U trunk/src/lib/krb5/krb/ser_eblk.c U trunk/src/lib/krb5/krb/ser_key.c U trunk/src/lib/krb5/os/localaddr.c U trunk/src/lib/krb5/os/locate_kdc.c U trunk/src/lib/krb5/os/sendto_kdc.c U trunk/src/lib/krb5/rcache/rc_dfl.c From raeburn at MIT.EDU Wed Aug 6 23:06:50 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 6 Aug 2008 23:06:50 -0400 (EDT) Subject: svn rev #20631: trunk/src/lib/krb5/asn.1/ Message-ID: <200808070306.XAA01463@drugstore.mit.edu> Commit By: raeburn Log Message: get_eoc() is always followed by next_tag(), so don't bother setting the variables that it's about to clobber. Since we don't need any of the tag info at the call site, push it down into the helper function. Changed Files: U trunk/src/lib/krb5/asn.1/asn1_k_decode.c U trunk/src/lib/krb5/asn.1/krb5_decode.c From raeburn at MIT.EDU Wed Aug 6 23:29:52 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 6 Aug 2008 23:29:52 -0400 (EDT) Subject: svn rev #20632: trunk/src/lib/krb5/asn.1/ Message-ID: <200808070329.XAA01803@drugstore.mit.edu> Commit By: raeburn Log Message: sequence_of_no_tagvars declared variables used only in end_sequence_of_no_tagvars and only as unnecessary temporaries, so get rid of them; also, push most of the work of the latter macro into a helper function. Changed Files: U trunk/src/lib/krb5/asn.1/asn1_k_decode.c From raeburn at MIT.EDU Thu Aug 7 11:54:36 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Thu, 7 Aug 2008 11:54:36 -0400 (EDT) Subject: svn rev #20633: trunk/src/lib/kdb/ Message-ID: <200808071554.LAA15818@drugstore.mit.edu> Commit By: raeburn Log Message: Don't leak attr_types storage on error. Changed Files: U trunk/src/lib/kdb/kdb_convert.c From raeburn at MIT.EDU Thu Aug 7 14:37:28 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Thu, 7 Aug 2008 14:37:28 -0400 (EDT) Subject: svn rev #20634: trunk/src/lib/krb5/ccache/ Message-ID: <200808071837.OAA17951@drugstore.mit.edu> Commit By: raeburn Log Message: Don't use memcmp for comparing structures of values. Changed Files: U trunk/src/lib/krb5/ccache/cc_retr.c From raeburn at MIT.EDU Thu Aug 7 17:45:16 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Thu, 7 Aug 2008 17:45:16 -0400 (EDT) Subject: svn rev #20635: trunk/src/lib/des425/ Message-ID: <200808072145.RAA24184@drugstore.mit.edu> Commit By: raeburn Log Message: Disable CONFIG_SMALL optimizations for now. Changed Files: U trunk/src/lib/des425/pcbc_encrypt.c From raeburn at MIT.EDU Thu Aug 7 17:46:34 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Thu, 7 Aug 2008 17:46:34 -0400 (EDT) Subject: svn rev #20636: trunk/src/ Message-ID: <200808072146.RAA24305@drugstore.mit.edu> Commit By: raeburn Log Message: New config option to enable size optimizations. Changed Files: U trunk/src/aclocal.m4 From raeburn at MIT.EDU Fri Aug 8 12:06:48 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Fri, 8 Aug 2008 12:06:48 -0400 (EDT) Subject: svn rev #20637: trunk/src/include/ Message-ID: <200808081606.MAA08441@drugstore.mit.edu> Commit By: raeburn Log Message: If krb5int_pthread_loaded is a function and we're using gcc, give it 'const' attribute. Changed Files: U trunk/src/include/k5-thread.h From tlyu at MIT.EDU Mon Aug 11 11:08:05 2008 From: tlyu at MIT.EDU (tlyu@MIT.EDU) Date: Mon, 11 Aug 2008 11:08:05 -0400 (EDT) Subject: svn rev #20638: branches/krb5-1-6/ src/windows/identity/ui/ Message-ID: <200808111508.LAA15320@drugstore.mit.edu> Commit By: tlyu Log Message: ticket: 5605 version_fixed: 1.6.4 status: resolved pull up r20570 from trunk r20570 at cathode-dark-space: jaltman | 2008-07-23 10:38:27 -0400 ticket: 5605 tags: pullup cw_handle_header_msg(): The behavior of the HDN_ENDTRACK notification has changed slightly on Vista. HDM_GETITEMRECT, when used while handling HDN_ENDTRACK, returns the item extents that were there prior to the user starting the resizing operation. Earlier it would return the extents that resulted from the resizing operation. This resulted in a visual update problem on Windows Vista/2008 in the NIM Advanced View. Changed Files: _U branches/krb5-1-6/ U branches/krb5-1-6/src/windows/identity/ui/credwnd.c From tlyu at MIT.EDU Mon Aug 11 11:08:24 2008 From: tlyu at MIT.EDU (tlyu@MIT.EDU) Date: Mon, 11 Aug 2008 11:08:24 -0400 (EDT) Subject: svn rev #20639: branches/krb5-1-6/ src/windows/identity/plugins/common/ Message-ID: <200808111508.LAA15405@drugstore.mit.edu> Commit By: tlyu Log Message: ticket: 6046 version_fixed: 1.6.4 status: resolved pull up r20571 from trunk r20571 at cathode-dark-space: jaltman | 2008-07-23 10:44:50 -0400 ticket: 6046 tags: pullup The /src/windows/identity/plugins/common/dynimport.{c,h} files are used by the NIM Kerberos v5 plug-ins for run-time dynamic linking. They currently do not declare or import the following functions: krb5_get_error_message() krb5_free_error_message() krb5_clear_error_message() This patch adds declarations and definitions required for locating these functions. Relies on the addition of these functions to the prototype list in the Pismere loadfuncs-krb5.h. See ticket 6045. Changed Files: _U branches/krb5-1-6/ U branches/krb5-1-6/src/windows/identity/plugins/common/dynimport.c U branches/krb5-1-6/src/windows/identity/plugins/common/dynimport.h From tlyu at MIT.EDU Mon Aug 11 11:08:52 2008 From: tlyu at MIT.EDU (tlyu@MIT.EDU) Date: Mon, 11 Aug 2008 11:08:52 -0400 (EDT) Subject: svn rev #20641: branches/krb5-1-6/ src/windows/identity/kherr/ Message-ID: <200808111508.LAA15577@drugstore.mit.edu> Commit By: tlyu Log Message: ticket: 6047 version_fixed: 1.6.4 pull up r20573 from trunk r20573 at cathode-dark-space: jaltman | 2008-07-23 11:09:15 -0400 ticket: 6047 tags: pullup The NIM error reporting functions (in src/windows/identity/kherr ) keep track of the the error message with the highest severity level that was reported for a specific error reporting context. However, if another error message of the same severity is reported, the error message being tracked will be updated to be the newly received error. The user will often only be notified of the error message that was tracked for a specific operation. Therefore, tracking the last message with the highest priority has the unfortunate side-effect of not reporting the cause of a failure. This patch changes the condition for updating the tracked error message to be the first message with the highest severity. Changed Files: _U branches/krb5-1-6/ U branches/krb5-1-6/src/windows/identity/kherr/kherr.c From tlyu at MIT.EDU Mon Aug 11 11:08:38 2008 From: tlyu at MIT.EDU (tlyu@MIT.EDU) Date: Mon, 11 Aug 2008 11:08:38 -0400 (EDT) Subject: svn rev #20640: branches/krb5-1-6/ src/windows/identity/plugins/krb5/ Message-ID: <200808111508.LAA15491@drugstore.mit.edu> Commit By: tlyu Log Message: ticket: 5745 version_fixed: 1.6.4 status: resolved pull up r20572 from trunk r20572 at cathode-dark-space: jaltman | 2008-07-23 11:04:26 -0400 ticket: 5745 tags: pullup This patch modifies the NIM Kerberos v5 plug-in to use the krb5_get_error_message() function to look up the error string if the call to krb5_get_init_creds_password() fails. If the call to krb5_get_error_message() fails, the caller will failover to the previous method of looking up a suitable error message based on the error code. Changed Files: _U branches/krb5-1-6/ U branches/krb5-1-6/src/windows/identity/plugins/krb5/krb5funcs.c U branches/krb5-1-6/src/windows/identity/plugins/krb5/krb5funcs.h U branches/krb5-1-6/src/windows/identity/plugins/krb5/krb5newcreds.c U branches/krb5-1-6/src/windows/identity/plugins/krb5/krbcred.h From tlyu at MIT.EDU Tue Aug 12 16:17:04 2008 From: tlyu at MIT.EDU (tlyu@MIT.EDU) Date: Tue, 12 Aug 2008 16:17:04 -0400 (EDT) Subject: svn rev #20642: trunk/ src/lib/crypto/des/ src/lib/des425/ Message-ID: <200808122017.QAA02092@drugstore.mit.edu> Commit By: tlyu Log Message: ticket: 6070 Update copyright notices to reflect donation of DES implementation by Dennis Ferguson. Changed Files: _U trunk/ U trunk/src/lib/crypto/des/f_cbc.c U trunk/src/lib/crypto/des/f_cksum.c U trunk/src/lib/crypto/des/f_sched.c U trunk/src/lib/crypto/des/f_tables.c U trunk/src/lib/crypto/des/f_tables.h U trunk/src/lib/des425/pcbc_encrypt.c From raeburn at MIT.EDU Tue Aug 12 16:20:41 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Tue, 12 Aug 2008 16:20:41 -0400 (EDT) Subject: svn rev #20643: trunk/src/util/support/ Message-ID: <200808122020.QAA02200@drugstore.mit.edu> Commit By: raeburn Log Message: Always define krb5int_pthread_loaded, for consistency. Changed Files: U trunk/src/util/support/threads.c From raeburn at MIT.EDU Tue Aug 12 16:21:30 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Tue, 12 Aug 2008 16:21:30 -0400 (EDT) Subject: svn rev #20644: trunk/src/util/support/ Message-ID: <200808122021.QAA02288@drugstore.mit.edu> Commit By: raeburn Log Message: Disable caching on Mac for now. Changed Files: U trunk/src/util/support/cache-addrinfo.h From raeburn at MIT.EDU Tue Aug 12 16:31:21 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Tue, 12 Aug 2008 16:31:21 -0400 (EDT) Subject: svn rev #20645: trunk/src/config/ Message-ID: <200808122031.QAA02452@drugstore.mit.edu> Commit By: raeburn Log Message: Actually use the export list for Darwin libraries. Changed Files: U trunk/src/config/shlib.conf From raeburn at MIT.EDU Tue Aug 12 16:52:40 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Tue, 12 Aug 2008 16:52:40 -0400 (EDT) Subject: svn rev #20646: trunk/src/ util/ util/collected-client-lib/ Message-ID: <200808122052.QAA02790@drugstore.mit.edu> Commit By: raeburn Log Message: Add a new directory, configured but not built by default, and never installed, where we can build the main client libraries all together into one library, and experiment with configuration changes for a client-only library. Changed Files: U trunk/src/configure.in A trunk/src/util/collected-client-lib/ A trunk/src/util/collected-client-lib/Makefile.in A trunk/src/util/collected-client-lib/libcollected.exports From raeburn at MIT.EDU Tue Aug 12 17:10:50 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Tue, 12 Aug 2008 17:10:50 -0400 (EDT) Subject: svn rev #20647: trunk/src/util/collected-client-lib/ Message-ID: <200808122110.RAA03477@drugstore.mit.edu> Commit By: raeburn Log Message: Shorter export list, dumping a bunch of stuff most clients probably would't need. Changed Files: U trunk/src/util/collected-client-lib/libcollected.exports From raeburn at MIT.EDU Tue Aug 12 17:28:31 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Tue, 12 Aug 2008 17:28:31 -0400 (EDT) Subject: svn rev #20648: trunk/src/lib/crypto/ aes/ des/ md4/ md5/ sha1/ Message-ID: <200808122128.RAA03693@drugstore.mit.edu> Commit By: raeburn Log Message: If CONFIG_SMALL_NO_CRYPTO is defined, turn off CONFIG_SMALL changes for crypto code only. Changed Files: U trunk/src/lib/crypto/aes/aesopt.h U trunk/src/lib/crypto/des/f_cbc.c U trunk/src/lib/crypto/des/f_tables.h U trunk/src/lib/crypto/md4/md4.c U trunk/src/lib/crypto/md5/md5.c U trunk/src/lib/crypto/sha1/shs.c From raeburn at MIT.EDU Tue Aug 12 18:14:45 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Tue, 12 Aug 2008 18:14:45 -0400 (EDT) Subject: svn rev #20649: trunk/src/lib/krb5/ccache/ Message-ID: <200808122214.SAA04100@drugstore.mit.edu> Commit By: raeburn Log Message: Rewrite the building of the ccache-type linked list to be linear instead of branched, and thus a bit easier to follow and modify. If NO_FILE_CCACHE is defined, leave the file cache out of the list, and (if we're not using ccapi) use the memory cache as the default. Changed Files: U trunk/src/lib/krb5/ccache/ccbase.c U trunk/src/lib/krb5/ccache/ccdefops.c From lxs at MIT.EDU Wed Aug 13 15:49:51 2008 From: lxs at MIT.EDU (lxs@MIT.EDU) Date: Wed, 13 Aug 2008 15:49:51 -0400 (EDT) Subject: svn rev #20650: trunk/src/ kadmin/cli/ lib/crypto/arcfour/ Message-ID: <200808131949.PAA18130@drugstore.mit.edu> Commit By: lxs Log Message: ticket: new subject: Use a valid UTF8 password for randkey password KfM RC4 string to key function expects password to be valid UTF8 Changed Files: U trunk/src/kadmin/cli/kadmin.c U trunk/src/lib/crypto/arcfour/arcfour_s2k.c From lxs at MIT.EDU Wed Aug 13 15:52:22 2008 From: lxs at MIT.EDU (lxs@MIT.EDU) Date: Wed, 13 Aug 2008 15:52:22 -0400 (EDT) Subject: svn rev #20651: trunk/src/lib/kadm5/ Message-ID: <200808131952.PAA18222@drugstore.mit.edu> Commit By: lxs Log Message: ticket: new subject: Open log file for appending only, not also reading Changed Files: U trunk/src/lib/kadm5/logger.c From raeburn at MIT.EDU Wed Aug 13 19:32:12 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 13 Aug 2008 19:32:12 -0400 (EDT) Subject: svn rev #20652: trunk/src/ lib/krb5/asn.1/ lib/krb5/os/ Message-ID: <200808132332.TAA19900@drugstore.mit.edu> Commit By: raeburn Log Message: ticket: new subject: Don't build PKINIT ASN.1 support code if not building PKINIT plugin If --disable-pkinit is given at configure time, don't build the PKINIT plugin. If the PKINIT plugin is not going to be built, define DISABLE_PKINIT. If DISABLE_PKINIT is defined, don't build the PKINIT-related ASN.1 encoding and decoding routines, and fill their slots in the accessor function table with null pointers. Tweak the accessor table initialization to use conditionally-varying macros rather than conditionally selecting between two blocks of invocations of fixed macros. Changed Files: U trunk/src/configure.in U trunk/src/lib/krb5/asn.1/asn1_k_decode.c U trunk/src/lib/krb5/asn.1/asn1_k_encode.c U trunk/src/lib/krb5/os/accessor.c From epeisach at MIT.EDU Thu Aug 14 00:44:45 2008 From: epeisach at MIT.EDU (epeisach@MIT.EDU) Date: Thu, 14 Aug 2008 00:44:45 -0400 (EDT) Subject: svn rev #20653: trunk/src/lib/krb5/ccache/ Message-ID: <200808140444.AAA22229@drugstore.mit.edu> Commit By: epeisach Log Message: ticket: new subject: krb5_fcc_resolve file locking error on malloc failuer In krb5_fcc_resolve, on malloc failure, the data->lock mutex needs to be destroyed. Unfortunately, this is done with the mutex is still locked. When thread debugging code is enabled, this results in aeg fault. Also - in krb5_fcc_generate_new, a strdup failure would result in the krb5int_cc_file_mutex being unlocked twice. [I have a modified version of valgrind in which I can signal after a certain number of mallocs for it to fail - I vary the allocation number from 1300 to 0 - and see what breaks - some memory leaks will be fixed separately] Changed Files: U trunk/src/lib/krb5/ccache/cc_file.c From epeisach at MIT.EDU Thu Aug 14 00:55:15 2008 From: epeisach at MIT.EDU (epeisach@MIT.EDU) Date: Thu, 14 Aug 2008 00:55:15 -0400 (EDT) Subject: svn rev #20654: trunk/src/lib/krb5/ccache/ Message-ID: <200808140455.AAA22384@drugstore.mit.edu> Commit By: epeisach Log Message: subject: krb5_fcc_read_addrs returns pointer to released memory on malloc failre In cleanup code on malloc failure, addresses are released including pointer to the krb5_address * - but the freed value is returned to caller. Clear pointer. Changed Files: U trunk/src/lib/krb5/ccache/cc_file.c From epeisach at MIT.EDU Thu Aug 14 01:09:12 2008 From: epeisach at MIT.EDU (epeisach@MIT.EDU) Date: Thu, 14 Aug 2008 01:09:12 -0400 (EDT) Subject: svn rev #20655: trunk/src/lib/krb5/ccache/ Message-ID: <200808140509.BAA22609@drugstore.mit.edu> Commit By: epeisach Log Message: subject: Error return from krb5int_random_string not tested in ccache code krb5int_random_string should probably only fail on malloc failure. Test for an error return from the function and cleanup properly (release mutex, return error instead of using uninitialized memory). Changed Files: U trunk/src/lib/krb5/ccache/cc_keyring.c U trunk/src/lib/krb5/ccache/cc_memory.c From epeisach at MIT.EDU Thu Aug 14 12:25:30 2008 From: epeisach at MIT.EDU (epeisach@MIT.EDU) Date: Thu, 14 Aug 2008 12:25:30 -0400 (EDT) Subject: svn rev #20657: trunk/src/lib/krb5/krb/ Message-ID: <200808141625.MAA29735@drugstore.mit.edu> Commit By: epeisach Log Message: In krb5int_copy_creds_contents - if we run out of memory, do not release pointer to output creds structure that is passed in by caller. Changed Files: U trunk/src/lib/krb5/krb/copy_creds.c From epeisach at MIT.EDU Thu Aug 14 12:40:07 2008 From: epeisach at MIT.EDU (epeisach@MIT.EDU) Date: Thu, 14 Aug 2008 12:40:07 -0400 (EDT) Subject: svn rev #20658: trunk/src/lib/krb5/ccache/ Message-ID: <200808141640.MAA29911@drugstore.mit.edu> Commit By: epeisach Log Message: In parsing principal - if run out memory - clean up after ourselves. Changed Files: U trunk/src/lib/krb5/ccache/cc_file.c U trunk/src/lib/krb5/ccache/cc_keyring.c From epeisach at MIT.EDU Thu Aug 14 12:22:49 2008 From: epeisach at MIT.EDU (epeisach@MIT.EDU) Date: Thu, 14 Aug 2008 12:22:49 -0400 (EDT) Subject: svn rev #20656: trunk/src/lib/krb5/krb/ Message-ID: <200808141622.MAA29638@drugstore.mit.edu> Commit By: epeisach Log Message: Clean up memory leak in krb5_build_principal if we run out of memory while building pricipal. Changed Files: U trunk/src/lib/krb5/krb/bld_princ.c From raeburn at MIT.EDU Thu Aug 14 17:32:59 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Thu, 14 Aug 2008 17:32:59 -0400 (EDT) Subject: svn rev #20659: trunk/src/ lib/krb5/asn.1/ lib/krb5/os/ Message-ID: <200808142132.RAA04810@drugstore.mit.edu> Commit By: raeburn Log Message: If the LDAP KDB back end is being built, define ENABLE_LDAP. If ENABLE_LDAP is not defined, don't build the LDAP KDB ASN.1 encoding and decoding functions, and use null pointers for them in the accessor function table. Changed Files: U trunk/src/configure.in U trunk/src/lib/krb5/asn.1/ldap_key_seq.c U trunk/src/lib/krb5/os/accessor.c From raeburn at MIT.EDU Thu Aug 14 18:59:56 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Thu, 14 Aug 2008 18:59:56 -0400 (EDT) Subject: svn rev #20660: trunk/src/ Message-ID: <200808142259.SAA05471@drugstore.mit.edu> Commit By: raeburn Log Message: Only add -Os for size optimizations if CFLAGS wasn't specified already. If the configure-generated CFLAGS string is one of the usual ones with -O2, replace -O2 rather than appending, since -Os will override previously specified optimization levels anyways. Changed Files: U trunk/src/aclocal.m4 From wfiveash at MIT.EDU Thu Aug 14 20:38:44 2008 From: wfiveash at MIT.EDU (wfiveash@MIT.EDU) Date: Thu, 14 Aug 2008 20:38:44 -0400 (EDT) Subject: svn rev #20661: trunk/src/ include/ kadmin/dbutil/ kdc/ lib/kadm5/ lib/kadm5/srv/ ... Message-ID: <200808150038.UAA06285@drugstore.mit.edu> Commit By: wfiveash Log Message: ticket: 194 a stash file is not a keytab Note, this is the commit for the associated Krb Consortium project: Projects/Masterkey Keytab Stash Changed Files: U trunk/src/configure.in U trunk/src/include/k5-int.h U trunk/src/include/kdb.h U trunk/src/kadmin/dbutil/dump.c U trunk/src/kadmin/dbutil/kdb5_create.c U trunk/src/kadmin/dbutil/kdb5_stash.c U trunk/src/kadmin/dbutil/kdb5_util.M U trunk/src/kadmin/dbutil/kdb5_util.c U trunk/src/kdc/main.c U trunk/src/lib/kadm5/admin.h U trunk/src/lib/kadm5/alt_prof.c U trunk/src/lib/kadm5/srv/server_kdb.c U trunk/src/lib/kadm5/unit-test/api.2/init-v2.exp U trunk/src/lib/kdb/kdb5.c U trunk/src/lib/kdb/kdb5.h U trunk/src/lib/kdb/kdb_default.c U trunk/src/lib/krb5/keytab/kt_file.c U trunk/src/lib/krb5/keytab/kt_memory.c U trunk/src/lib/krb5/keytab/kt_srvtab.c U trunk/src/plugins/kdb/ldap/ldap_util/kdb5_ldap_realm.c U trunk/src/plugins/kdb/ldap/ldap_util/kdb5_ldap_util.M U trunk/src/plugins/kdb/ldap/ldap_util/kdb5_ldap_util.c U trunk/src/tests/Makefile.in U trunk/src/tests/create/kdb5_mkdums.c A trunk/src/tests/mkeystash_compat/ U trunk/src/tests/verify/kdb5_verify.c From epeisach at MIT.EDU Fri Aug 15 14:46:14 2008 From: epeisach at MIT.EDU (epeisach@MIT.EDU) Date: Fri, 15 Aug 2008 14:46:14 -0400 (EDT) Subject: svn rev #20662: trunk/src/ include/ lib/krb5/ccache/ Message-ID: <200808151846.OAA17343@drugstore.mit.edu> Commit By: epeisach Log Message: Move prototype for krb5int_random_string from k5-int.h to cc-int.h as it is private to the ccache code. Include cc-int.h where needed, and update Makefile.in dependencies. Changed Files: U trunk/src/include/k5-int.h U trunk/src/lib/krb5/ccache/Makefile.in U trunk/src/lib/krb5/ccache/cc-int.h U trunk/src/lib/krb5/ccache/cc_keyring.c U trunk/src/lib/krb5/ccache/cc_memory.c From lxs at MIT.EDU Fri Aug 15 18:17:10 2008 From: lxs at MIT.EDU (lxs@MIT.EDU) Date: Fri, 15 Aug 2008 18:17:10 -0400 (EDT) Subject: svn rev #20663: trunk/src/kim/lib/ mac/ Message-ID: <200808152217.SAA19043@drugstore.mit.edu> Commit By: lxs Log Message: ticket: new subject: mac port of kim should not depend on kipc kipc is not necessarily built Changed Files: U trunk/src/kim/lib/kim_ccache.c U trunk/src/kim/lib/mac/kim_os_identity.c From lxs at MIT.EDU Fri Aug 15 18:19:02 2008 From: lxs at MIT.EDU (lxs@MIT.EDU) Date: Fri, 15 Aug 2008 18:19:02 -0400 (EDT) Subject: svn rev #20664: trunk/src/lib/krb5/ccache/ccapi/ Message-ID: <200808152219.SAA19139@drugstore.mit.edu> Commit By: lxs Log Message: ticket: new subject: Conditionalize building of CCAPI ccache type on USE_CCAPI Still refer to Windows by OS macro because KfW builds do not set USE_CCAPI. Changed Files: U trunk/src/lib/krb5/ccache/ccapi/stdcc.c U trunk/src/lib/krb5/ccache/ccapi/stdcc.h U trunk/src/lib/krb5/ccache/ccapi/stdcc_util.c U trunk/src/lib/krb5/ccache/ccapi/stdcc_util.h From epeisach at MIT.EDU Fri Aug 15 21:15:00 2008 From: epeisach at MIT.EDU (epeisach@MIT.EDU) Date: Fri, 15 Aug 2008 21:15:00 -0400 (EDT) Subject: svn rev #20665: trunk/src/ include/ lib/krb5/ccache/ Message-ID: <200808160115.VAA20456@drugstore.mit.edu> Commit By: epeisach Log Message: Move internal cccursor structures/prototypes to the ccache private include file. Functions are not exported from library. Changed Files: U trunk/src/include/k5-int.h U trunk/src/lib/krb5/ccache/Makefile.in U trunk/src/lib/krb5/ccache/cc-int.h U trunk/src/lib/krb5/ccache/cccursor.c From epeisach at MIT.EDU Sat Aug 16 09:01:41 2008 From: epeisach at MIT.EDU (epeisach@MIT.EDU) Date: Sat, 16 Aug 2008 09:01:41 -0400 (EDT) Subject: svn rev #20666: trunk/src/lib/krb5/krb/ Message-ID: <200808161301.JAA26647@drugstore.mit.edu> Commit By: epeisach Log Message: In copying a credential - if we run out memory - the cleanup code failed to clear the second_ticket. Changed Files: U trunk/src/lib/krb5/krb/copy_creds.c From epeisach at MIT.EDU Sat Aug 16 09:03:31 2008 From: epeisach at MIT.EDU (epeisach@MIT.EDU) Date: Sat, 16 Aug 2008 09:03:31 -0400 (EDT) Subject: svn rev #20667: trunk/src/lib/krb5/ccache/ Message-ID: <200808161303.JAA26740@drugstore.mit.edu> Commit By: epeisach Log Message: In parsing authorization data, if run out of memory, the authorization data was released, but the pointer not zeroed. This resulted in higher level code trying to free it again. Changed Files: U trunk/src/lib/krb5/ccache/cc_file.c U trunk/src/lib/krb5/ccache/cc_keyring.c From epeisach at MIT.EDU Sun Aug 17 19:34:43 2008 From: epeisach at MIT.EDU (epeisach@MIT.EDU) Date: Sun, 17 Aug 2008 19:34:43 -0400 (EDT) Subject: svn rev #20668: trunk/src/lib/krb5/ccache/ Message-ID: <200808172334.TAA13964@drugstore.mit.edu> Commit By: epeisach Log Message: Using gcov, it was noted that the tests were never including authdata in the test credential - and a segment of code was never tested. Add some fake authdata to the test creds. Changed Files: U trunk/src/lib/krb5/ccache/t_cc.c From lxs at MIT.EDU Mon Aug 18 13:08:29 2008 From: lxs at MIT.EDU (lxs@MIT.EDU) Date: Mon, 18 Aug 2008 13:08:29 -0400 (EDT) Subject: svn rev #20669: trunk/src/kim/agent/mac/resources/English.lproj/ Message-ID: <200808181708.NAA23361@drugstore.mit.edu> Commit By: lxs Log Message: Updated bindings. Incomplete but commiting to avoid losing changes. Changed Files: U trunk/src/kim/agent/mac/resources/English.lproj/SelectIdentity.xib From lxs at MIT.EDU Tue Aug 19 12:43:20 2008 From: lxs at MIT.EDU (lxs@MIT.EDU) Date: Tue, 19 Aug 2008 12:43:20 -0400 (EDT) Subject: svn rev #20670: trunk/src/ include/ include/kim/ kim/agent/mac/ kim/lib/ kim/lib/mac/ ... Message-ID: <200808191643.MAA04900@drugstore.mit.edu> Commit By: lxs Log Message: ticket: 6055 status: open Modified hints APIs to be a single API that takes string keys. Removed error object. Changed error message API to use thread specific data. Split out debugging API into separate files. Changed Files: U trunk/src/include/k5-thread.h U trunk/src/include/kim/kim_ccache.h U trunk/src/include/kim/kim_credential.h U trunk/src/include/kim/kim_error.h U trunk/src/include/kim/kim_identity.h U trunk/src/include/kim/kim_options.h U trunk/src/include/kim/kim_preferences.h U trunk/src/include/kim/kim_selection_hints.h U trunk/src/include/kim/kim_string.h U trunk/src/include/kim/kim_types.h U trunk/src/kim/agent/mac/Identities.m U trunk/src/kim/lib/kim.exports U trunk/src/kim/lib/kim_ccache.c U trunk/src/kim/lib/kim_credential.c A trunk/src/kim/lib/kim_debug.c A trunk/src/kim/lib/kim_debug_private.h U trunk/src/kim/lib/kim_error.c U trunk/src/kim/lib/kim_error_code.et U trunk/src/kim/lib/kim_error_private.h U trunk/src/kim/lib/kim_library.c U trunk/src/kim/lib/kim_library_private.h U trunk/src/kim/lib/kim_options.c U trunk/src/kim/lib/kim_preferences.c U trunk/src/kim/lib/kim_private.h U trunk/src/kim/lib/kim_selection_hints.c A trunk/src/kim/lib/mac/kim_os_debug.c U trunk/src/kim/lib/mac/kim_os_library.c U trunk/src/kim/lib/mac/kim_os_preferences.c U trunk/src/kim/lib/mac/kim_os_selection_hints.c U trunk/src/kim/test/test_kim_common.c U trunk/src/kim/test/test_kim_identity.c U trunk/src/kim/test/test_kim_preferences.c From lxs at MIT.EDU Tue Aug 19 12:49:18 2008 From: lxs at MIT.EDU (lxs@MIT.EDU) Date: Tue, 19 Aug 2008 12:49:18 -0400 (EDT) Subject: svn rev #20671: trunk/src/kim/lib/ Message-ID: <200808191649.MAA05074@drugstore.mit.edu> Commit By: lxs Log Message: ticket: 6055 status: open Fixed export list for new hints functions and fixed calls to set error message. Changed Files: U trunk/src/kim/lib/kim.exports U trunk/src/kim/lib/kim_ccache.c U trunk/src/kim/lib/kim_identity.c From raeburn at MIT.EDU Tue Aug 19 15:37:17 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Tue, 19 Aug 2008 15:37:17 -0400 (EDT) Subject: svn rev #20672: trunk/src/ Message-ID: <200808191937.PAA06552@drugstore.mit.edu> Commit By: raeburn Log Message: Default to not building krb4 support. Changed Files: U trunk/src/aclocal.m4 From lxs at MIT.EDU Tue Aug 19 16:09:23 2008 From: lxs at MIT.EDU (lxs@MIT.EDU) Date: Tue, 19 Aug 2008 16:09:23 -0400 (EDT) Subject: svn rev #20673: trunk/src/kim/ agent/mac/ lib/ Message-ID: <200808192009.QAA06866@drugstore.mit.edu> Commit By: lxs Log Message: ticket: 6055 status: open Get KerberosAgent building again after KIM changes. Changed Files: U trunk/src/kim/agent/mac/Identities.h U trunk/src/kim/agent/mac/Identities.m U trunk/src/kim/agent/mac/KerberosAgentPrefix.pch U trunk/src/kim/lib/kim.exports From lxs at MIT.EDU Tue Aug 19 17:04:57 2008 From: lxs at MIT.EDU (lxs@MIT.EDU) Date: Tue, 19 Aug 2008 17:04:57 -0400 (EDT) Subject: svn rev #20674: trunk/src/util/profile/ Message-ID: <200808192104.RAA07397@drugstore.mit.edu> Commit By: lxs Log Message: ticket: new owner: raeburn subject: profile write code should only quote empty strings Assigned to Ken for review. Changed Files: U trunk/src/util/profile/prof_parse.c From raeburn at MIT.EDU Tue Aug 19 19:07:13 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Tue, 19 Aug 2008 19:07:13 -0400 (EDT) Subject: svn rev #20675: trunk/src/lib/krb5/asn.1/ Message-ID: <200808192307.TAA08279@drugstore.mit.edu> Commit By: raeburn Log Message: ticket: 6076 Fix broken build -- conditionalize some stuff on DISABLE_PKINIT that I missed last time. Changed Files: U trunk/src/lib/krb5/asn.1/krb5_decode.c U trunk/src/lib/krb5/asn.1/krb5_encode.c From raeburn at MIT.EDU Tue Aug 19 19:14:41 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Tue, 19 Aug 2008 19:14:41 -0400 (EDT) Subject: svn rev #20676: trunk/src/appl/bsd/ Message-ID: <200808192314.TAA08400@drugstore.mit.edu> Commit By: raeburn Log Message: Update krb4 test to use aclocal.m4 macro and default to disabled. Changed Files: U trunk/src/appl/bsd/configure.in From lxs at MIT.EDU Wed Aug 20 13:58:08 2008 From: lxs at MIT.EDU (lxs@MIT.EDU) Date: Wed, 20 Aug 2008 13:58:08 -0400 (EDT) Subject: svn rev #20677: trunk/src/kim/lib/mac/ Message-ID: <200808201758.NAA18337@drugstore.mit.edu> Commit By: lxs Log Message: Added some carriage returns to decrease line length. Changed Files: U trunk/src/kim/lib/mac/kim_os_string.c From lxs at MIT.EDU Wed Aug 20 14:46:46 2008 From: lxs at MIT.EDU (lxs@MIT.EDU) Date: Wed, 20 Aug 2008 14:46:46 -0400 (EDT) Subject: svn rev #20678: trunk/src/ccapi/server/ Message-ID: <200808201846.OAA18798@drugstore.mit.edu> Commit By: lxs Log Message: ticket: new subject: Notify clients on ccache deletion Clients watching a ccache or the cache collection should get a notification when the ccache is destroyed. Changed Files: U trunk/src/ccapi/server/ccs_cache_collection.c U trunk/src/ccapi/server/ccs_ccache.c U trunk/src/ccapi/server/ccs_ccache.h From lxs at MIT.EDU Wed Aug 20 14:58:05 2008 From: lxs at MIT.EDU (lxs@MIT.EDU) Date: Wed, 20 Aug 2008 14:58:05 -0400 (EDT) Subject: svn rev #20679: trunk/src/ ccapi/server/ ccapi/server/mac/ include/ Message-ID: <200808201858.OAA18993@drugstore.mit.edu> Commit By: lxs Log Message: ticket: new subject: Add support to send CFNotifications on ccache and cache collection changes Changed Files: U trunk/src/ccapi/server/ccs_cache_collection.c U trunk/src/ccapi/server/ccs_ccache.c A trunk/src/ccapi/server/ccs_os_notify.h A trunk/src/ccapi/server/mac/ccs_os_notify.c U trunk/src/include/CredentialsCache.h From tsitkova at MIT.EDU Wed Aug 20 17:09:17 2008 From: tsitkova at MIT.EDU (tsitkova@MIT.EDU) Date: Wed, 20 Aug 2008 17:09:17 -0400 (EDT) Subject: svn rev #20680: trunk/src/ lib/gssapi/ lib/gssapi/krb5/ lib/gssapi/mechglue/ ... Message-ID: <200808202109.RAA20775@drugstore.mit.edu> Commit By: tsitkova Log Message: Ticket:new Subject: lean client changes All changes are under LEAN_CLIENT macro. Application server functionality is disabled. Changed Files: U trunk/src/lib/gssapi/gss_libinit.c U trunk/src/lib/gssapi/krb5/accept_sec_context.c U trunk/src/lib/gssapi/krb5/acquire_cred.c U trunk/src/lib/gssapi/krb5/add_cred.c U trunk/src/lib/gssapi/krb5/export_sec_context.c U trunk/src/lib/gssapi/krb5/gssapiP_krb5.h U trunk/src/lib/gssapi/krb5/krb5_gss_glue.c U trunk/src/lib/gssapi/krb5/rel_cred.c U trunk/src/lib/gssapi/mechglue/g_accept_sec_context.c U trunk/src/lib/gssapi/mechglue/g_exp_sec_context.c U trunk/src/lib/gssapi/mechglue/g_imp_sec_context.c U trunk/src/lib/gssapi/spnego/gssapiP_spnego.h U trunk/src/lib/gssapi/spnego/spnego_mech.c U trunk/src/lib/kdb/kdb_default.c U trunk/src/lib/krb5/keytab/kt_file.c U trunk/src/lib/krb5/keytab/kt_memory.c U trunk/src/lib/krb5/keytab/kt_srvtab.c U trunk/src/lib/krb5/keytab/ktadd.c U trunk/src/lib/krb5/keytab/ktbase.c U trunk/src/lib/krb5/keytab/ktdefault.c U trunk/src/lib/krb5/keytab/ktfns.c U trunk/src/lib/krb5/keytab/ktfr_entry.c U trunk/src/lib/krb5/keytab/ktremove.c U trunk/src/lib/krb5/keytab/read_servi.c U trunk/src/lib/krb5/krb/gic_keytab.c U trunk/src/lib/krb5/krb/gic_pwd.c U trunk/src/lib/krb5/krb/in_tkt_sky.c U trunk/src/lib/krb5/krb/rd_req.c U trunk/src/lib/krb5/krb/rd_req_dec.c U trunk/src/lib/krb5/krb/ser_ctx.c U trunk/src/lib/krb5/krb/srv_dec_tkt.c U trunk/src/lib/krb5/krb5_libinit.c U trunk/src/lib/krb5/os/accessor.c U trunk/src/util/collected-client-lib/libcollected.exports U trunk/src/util/profile/prof_init.c From raeburn at MIT.EDU Thu Aug 21 21:20:25 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Thu, 21 Aug 2008 21:20:25 -0400 (EDT) Subject: svn rev #20681: trunk/src/ Message-ID: <200808220120.VAA06410@drugstore.mit.edu> Commit By: raeburn Log Message: Check for struct sockaddr_storage only in top-level configure script, not in code common to all. Use an existing AC_CHECK_TYPES invocation, not a special-purpose test. Eliminate now-unused KRB5_AC_CHECK_TYPE_WITH_HEADERS and KRB5_AC_CHECK_SOCKADDR_STORAGE macros. Merge KRB5_AC_CHECK_INET6 into the one place where it gets used. Changed Files: U trunk/src/aclocal.m4 U trunk/src/configure.in From lxs at MIT.EDU Fri Aug 22 11:34:21 2008 From: lxs at MIT.EDU (lxs@MIT.EDU) Date: Fri, 22 Aug 2008 11:34:21 -0400 (EDT) Subject: svn rev #20682: trunk/src/kim/lib/ Message-ID: <200808221534.LAA13554@drugstore.mit.edu> Commit By: lxs Log Message: Removed warnings of unused variable. Changed Files: U trunk/src/kim/lib/kim_library.c From lxs at MIT.EDU Fri Aug 22 11:34:47 2008 From: lxs at MIT.EDU (lxs@MIT.EDU) Date: Fri, 22 Aug 2008 11:34:47 -0400 (EDT) Subject: svn rev #20683: trunk/src/include/kim/ Message-ID: <200808221534.LAA13634@drugstore.mit.edu> Commit By: lxs Log Message: Updated documentation to be more specific about TLS impact. Changed Files: U trunk/src/include/kim/kim_error.h From lxs at MIT.EDU Fri Aug 22 11:36:33 2008 From: lxs at MIT.EDU (lxs@MIT.EDU) Date: Fri, 22 Aug 2008 11:36:33 -0400 (EDT) Subject: svn rev #20684: trunk/src/kim/lib/ Message-ID: <200808221536.LAA13726@drugstore.mit.edu> Commit By: lxs Log Message: ticket: new subject: KIM should not provide keytab functions when building lite framework Changed Files: A trunk/src/kim/lib/kim-lite.exports U trunk/src/kim/lib/kim_ccache.c U trunk/src/kim/lib/kim_credential.c From raeburn at MIT.EDU Fri Aug 22 11:56:33 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Fri, 22 Aug 2008 11:56:33 -0400 (EDT) Subject: svn rev #20685: trunk/src/ Message-ID: <200808221556.LAA14166@drugstore.mit.edu> Commit By: raeburn Log Message: New macro for testing whether the compiler supports a given command-line flag or not, and adding it to CFLAGS only if supported. Use it for GCC flag -Wno-format-zero-length, which we were testing for before, and for some additional flags: -Woverflow -Wstrict-overflow -Wmissing-format-attribute -Werror=declaration-after-statement -Wdeclaration-after-statement -Werror=variadic-macros -Wvariadic-macros. (The last few are because we've had some code contributions that assumed full C99 support, and our baseline is currently C89+, so if possible we want certain newer constructs flagged as errors.) Changed Files: U trunk/src/aclocal.m4 From raeburn at MIT.EDU Fri Aug 22 12:25:27 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Fri, 22 Aug 2008 12:25:27 -0400 (EDT) Subject: svn rev #20686: trunk/ src/lib/krb5/krb/ Message-ID: <200808221625.MAA14480@drugstore.mit.edu> Commit By: raeburn Log Message: Use capaths unconditionally. Update copyright. Changed Files: _U trunk/ U trunk/src/lib/krb5/krb/walk_rtree.c From raeburn at MIT.EDU Fri Aug 22 12:26:29 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Fri, 22 Aug 2008 12:26:29 -0400 (EDT) Subject: svn rev #20687: trunk/ src/lib/krb5/krb/ Message-ID: <200808221626.MAA14574@drugstore.mit.edu> Commit By: raeburn Log Message: Let walk_realm_tree tests fail for now, ignore them and keep going. Changed Files: _U trunk/ U trunk/src/lib/krb5/krb/Makefile.in From lxs at MIT.EDU Fri Aug 22 12:44:23 2008 From: lxs at MIT.EDU (lxs@MIT.EDU) Date: Fri, 22 Aug 2008 12:44:23 -0400 (EDT) Subject: svn rev #20688: trunk/src/ccapi/lib/mac/ Message-ID: <200808221644.MAA14799@drugstore.mit.edu> Commit By: lxs Log Message: ticket: new subject: CCAPI is leaking mach ports Need to destroy the mach ports instead of deallocating because we requested notifications on the port so just deallocating won't actually destroy the port. Also deallocate any port which was previously registered for notifications. Changed Files: U trunk/src/ccapi/lib/mac/ccapi_os_ipc.c From lxs at MIT.EDU Fri Aug 22 13:14:56 2008 From: lxs at MIT.EDU (lxs@MIT.EDU) Date: Fri, 22 Aug 2008 13:14:56 -0400 (EDT) Subject: svn rev #20689: tags/ Message-ID: <200808221714.NAA15193@drugstore.mit.edu> Commit By: lxs Log Message: Tagging for KfM 6.5a4 Changed Files: A tags/KfM_6.5a4/ From raeburn at MIT.EDU Mon Aug 25 13:41:00 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Mon, 25 Aug 2008 13:41:00 -0400 (EDT) Subject: svn rev #20690: trunk/src/include/ Message-ID: <200808251741.NAA21314@drugstore.mit.edu> Commit By: raeburn Log Message: ticket: 6090 Fix sense of test of lock call preparing to update debug info in k5_mutex_destroy. Thanks, Ezra. Changed Files: U trunk/src/include/k5-thread.h From raeburn at MIT.EDU Mon Aug 25 15:43:11 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Mon, 25 Aug 2008 15:43:11 -0400 (EDT) Subject: svn rev #20691: trunk/src/ config/ include/ include/krb5/ kdc/ lib/krb5/krb/ ... Message-ID: <200808251943.PAA22400@drugstore.mit.edu> Commit By: raeburn Log Message: ticket: 5565 Incorporate Apple's patch. Add a test authorization data scheme, in both built-in and plugin forms; built-in version is #ifdef'ed out. Update configury to create the build directory for the plugin, but don't build or install it by default. Create the new (and normally empty) authorization data plugin directory at install time. Add some (normally disabled) code to log authz data from rd_req. Fix up some comments that still refer to preauth plugins. Add some details in comments on the API, and why it's private for now. Make the plugin init context support work, by not passing null pointers. Changed Files: U trunk/src/Makefile.in U trunk/src/config/pre.in U trunk/src/configure.in A trunk/src/include/krb5/authdata_plugin.h U trunk/src/include/osconf.hin U trunk/src/kdc/Makefile.in U trunk/src/kdc/do_as_req.c A trunk/src/kdc/kdc_authdata.c U trunk/src/kdc/kdc_util.h U trunk/src/kdc/main.c U trunk/src/lib/krb5/krb/rd_req_dec.c A trunk/src/plugins/authdata/ A trunk/src/plugins/authdata/greet/ A trunk/src/plugins/authdata/greet/Makefile.in A trunk/src/plugins/authdata/greet/greet.exports A trunk/src/plugins/authdata/greet/greet_auth.c From raeburn at MIT.EDU Mon Aug 25 16:11:19 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Mon, 25 Aug 2008 16:11:19 -0400 (EDT) Subject: svn rev #20692: trunk/src/kdc/ Message-ID: <200808252011.QAA22875@drugstore.mit.edu> Commit By: raeburn Log Message: ticket: 5565 Update description of -k option: From the code it appears the default is des-cbc-crc, and it applies to entering passwords with -m. Changed Files: U trunk/src/kdc/krb5kdc.M From tlyu at MIT.EDU Mon Aug 25 19:08:18 2008 From: tlyu at MIT.EDU (tlyu@MIT.EDU) Date: Mon, 25 Aug 2008 19:08:18 -0400 (EDT) Subject: svn rev #20693: trunk/ src/plugins/kdb/db2/libdb2/test/ Message-ID: <200808252308.TAA24307@drugstore.mit.edu> Commit By: tlyu Log Message: Fix PROG_LIBPATH so in-tree tests work. Changed Files: _U trunk/ U trunk/src/plugins/kdb/db2/libdb2/test/Makefile.in From tlyu at MIT.EDU Tue Aug 26 14:05:55 2008 From: tlyu at MIT.EDU (tlyu@MIT.EDU) Date: Tue, 26 Aug 2008 14:05:55 -0400 (EDT) Subject: svn rev #20694: trunk/ src/lib/kadm5/ Message-ID: <200808261805.OAA03618@drugstore.mit.edu> Commit By: tlyu Log Message: whitespace Changed Files: _U trunk/ U trunk/src/lib/kadm5/admin.h From raeburn at MIT.EDU Tue Aug 26 15:34:18 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Tue, 26 Aug 2008 15:34:18 -0400 (EDT) Subject: svn rev #20695: trunk/src/include/ Message-ID: <200808261934.PAA04390@drugstore.mit.edu> Commit By: raeburn Log Message: Change non-debug version of k5_debug_log to int to silence some compiler warnings. Changed Files: U trunk/src/include/k5-thread.h From raeburn at MIT.EDU Tue Aug 26 20:21:56 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Tue, 26 Aug 2008 20:21:56 -0400 (EDT) Subject: svn rev #20696: trunk/ src/include/ src/util/et/ src/util/support/ Message-ID: <200808270021.UAA07100@drugstore.mit.edu> Commit By: raeburn Log Message: r820 at NOME-KING: raeburn | 2008-08-26 18:37:41 -0400 x r821 at NOME-KING: raeburn | 2008-08-26 18:51:10 -0400 Remove disabled statistics gathering support. r822 at NOME-KING: raeburn | 2008-08-26 18:57:20 -0400 Remove source location tracking. r823 at NOME-KING: raeburn | 2008-08-26 19:05:35 -0400 Delete DEBUG_THREADS code. r824 at NOME-KING: raeburn | 2008-08-26 19:18:59 -0400 Remove now-no-op assertion checks. r825 at NOME-KING: raeburn | 2008-08-26 19:29:49 -0400 Simplify some wrappers. r826 at NOME-KING: raeburn | 2008-08-26 19:38:23 -0400 Remove redundant comment. r827 at NOME-KING: raeburn | 2008-08-26 19:49:20 -0400 When pthreads must be checked for at run time, don't include the no-op _nothread_mutex stuff too. r828 at NOME-KING: raeburn | 2008-08-26 19:54:05 -0400 Remove remaining DEBUG_THREADS bits. r829 at NOME-KING: raeburn | 2008-08-26 20:00:22 -0400 fix up initializer r830 at NOME-KING: raeburn | 2008-08-26 20:10:37 -0400 Flatten a couple of structs wrapping single elements. r831 at NOME-KING: raeburn | 2008-08-26 20:14:01 -0400 Remove k5_pthread_mutex_*lock macros. r832 at NOME-KING: raeburn | 2008-08-26 20:19:14 -0400 Update comments a bit for lack of debug support. Changed Files: _U trunk/ U trunk/src/include/k5-thread.h U trunk/src/util/et/error_message.c U trunk/src/util/support/libkrb5support-fixed.exports U trunk/src/util/support/threads.c From raeburn at MIT.EDU Tue Aug 26 20:24:29 2008 From: raeburn at MIT.EDU (Ken Raeburn) Date: Tue, 26 Aug 2008 20:24:29 -0400 Subject: svn rev #20696: trunk/ src/include/ src/util/et/ src/util/support/ In-Reply-To: <200808270021.UAA07100@drugstore.mit.edu> References: <200808270021.UAA07100@drugstore.mit.edu> Message-ID: <2DC5186B-9318-43B6-B414-5070453F259F@mit.edu> Oops... thought svk was going to give me a chance to edit the message... it should've just read: Remove debug code from thread support. From raeburn at MIT.EDU Wed Aug 27 12:36:07 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 27 Aug 2008 12:36:07 -0400 (EDT) Subject: svn rev #20697: trunk/ src/ src/include/ src/kim/lib/ src/kim/lib/mac/ src/lib/crypto/ ... Message-ID: <200808271636.MAA14630@drugstore.mit.edu> Commit By: raeburn Log Message: ticket: 6096 status: open Based on patch from lxs, with some changes: Add several new gcc warning flags, used in the KfM build process. Put declarations before code. Fix a bunch of signed/unsigned type mixes, mostly by changing variable types to unsigned int. Fix constness in handling name of default ccache name. Make sure functions get declared with prototypes: krb5int_pthread_loaded krb5int_gmt_mktime krb5int_aes_encrypt krb5int_aes_decrypt gssint_mecherrmap_init gssint_mecherramp_get. Don't shadow global names: stat accept index open encrypt. Fix variable shadowing in LDAP ASN.1 support. Don't define unused krb5int_local_addresses. Don't export internal krb5_change_set_password. Fix error return indications from gssint_oid_to_mech. Create and use k5-gmt_mktime.h to provide one global declaration of krb5int_gmt_mktime, needed before we've generated krb5.h on some platforms. Not incorporated from initial patch: const changes in function signatures. Changed Files: _U trunk/ U trunk/src/aclocal.m4 A trunk/src/include/k5-gmt_mktime.h U trunk/src/include/k5-int.h U trunk/src/include/k5-thread.h U trunk/src/kim/lib/kim_preferences.c U trunk/src/kim/lib/mac/kim_os_string.c U trunk/src/lib/crypto/checksum_length.c U trunk/src/lib/crypto/cksumtype_to_string.c U trunk/src/lib/crypto/cksumtypes.c U trunk/src/lib/crypto/cksumtypes.h U trunk/src/lib/crypto/coll_proof_cksum.c U trunk/src/lib/crypto/des/f_parity.c U trunk/src/lib/crypto/des/string2key.c U trunk/src/lib/crypto/des/weak_key.c U trunk/src/lib/crypto/hash_provider/hash_crc32.c U trunk/src/lib/crypto/hash_provider/hash_md4.c U trunk/src/lib/crypto/hash_provider/hash_md5.c U trunk/src/lib/crypto/hash_provider/hash_sha1.c U trunk/src/lib/crypto/hmac.c U trunk/src/lib/crypto/keyed_cksum.c U trunk/src/lib/crypto/keyhash_provider/k5_md4des.c U trunk/src/lib/crypto/keyhash_provider/k5_md5des.c U trunk/src/lib/crypto/make_checksum.c U trunk/src/lib/crypto/pbkdf2.c U trunk/src/lib/crypto/sha1/shs.c U trunk/src/lib/crypto/string_to_cksumtype.c U trunk/src/lib/crypto/valid_cksumtype.c U trunk/src/lib/crypto/verify_checksum.c U trunk/src/lib/gssapi/generic/gssapiP_generic.h U trunk/src/lib/gssapi/generic/util_buffer.c U trunk/src/lib/gssapi/generic/util_errmap.c U trunk/src/lib/gssapi/gss_libinit.c U trunk/src/lib/gssapi/krb5/accept_sec_context.c U trunk/src/lib/gssapi/krb5/copy_ccache.c U trunk/src/lib/gssapi/krb5/import_sec_context.c U trunk/src/lib/gssapi/krb5/init_sec_context.c U trunk/src/lib/gssapi/krb5/inq_context.c U trunk/src/lib/gssapi/krb5/k5seal.c U trunk/src/lib/gssapi/krb5/krb5_gss_glue.c U trunk/src/lib/gssapi/krb5/set_allowable_enctypes.c U trunk/src/lib/gssapi/krb5/util_seed.c U trunk/src/lib/gssapi/mechglue/g_acquire_cred.c U trunk/src/lib/gssapi/mechglue/g_initialize.c U trunk/src/lib/gssapi/mechglue/g_inq_context.c U trunk/src/lib/gssapi/mechglue/g_rel_oid_set.c U trunk/src/lib/gssapi/mechglue/mglueP.h U trunk/src/lib/gssapi/mechglue/oid_ops.c U trunk/src/lib/gssapi/spnego/gssapiP_spnego.h U trunk/src/lib/gssapi/spnego/spnego_mech.c U trunk/src/lib/krb5/asn.1/asn1_decode.c U trunk/src/lib/krb5/asn.1/asn1_k_decode.c U trunk/src/lib/krb5/asn.1/asn1buf.c U trunk/src/lib/krb5/asn.1/asn1buf.h U trunk/src/lib/krb5/asn.1/ldap_key_seq.c U trunk/src/lib/krb5/ccache/ccdefault.c U trunk/src/lib/krb5/krb/gc_frm_kdc.c U trunk/src/lib/krb5/krb/pkinit_apple_cert_store.c U trunk/src/lib/krb5/krb/pkinit_apple_utils.c U trunk/src/lib/krb5/krb/preauth2.c U trunk/src/lib/krb5/krb/ser_ctx.c U trunk/src/lib/krb5/krb/srv_rcache.c U trunk/src/lib/krb5/krb/str_conv.c U trunk/src/lib/krb5/libkrb5.exports U trunk/src/lib/krb5/os/changepw.c U trunk/src/lib/krb5/os/gen_rname.c U trunk/src/lib/krb5/os/localaddr.c U trunk/src/lib/krb5/os/sendto_kdc.c U trunk/src/lib/krb5/rcache/rc_io.c U trunk/src/util/support/gmt_mktime.c From raeburn at MIT.EDU Wed Aug 27 12:45:56 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 27 Aug 2008 12:45:56 -0400 (EDT) Subject: svn rev #20698: trunk/src/ Message-ID: <200808271645.MAA14817@drugstore.mit.edu> Commit By: raeburn Log Message: Some helper rules for running Coverity Prevent. Changed Files: U trunk/src/Makefile.in From raeburn at MIT.EDU Wed Aug 27 18:31:57 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Wed, 27 Aug 2008 18:31:57 -0400 (EDT) Subject: svn rev #20699: trunk/src/kadmin/server/ Message-ID: <200808272231.SAA18092@drugstore.mit.edu> Commit By: raeburn Log Message: ticket: new subject: compile-time flag to disable iprop If DISABLE_IPROP is defined at compile time, don't listen for connections and don't register the service. (Doesn't currently disable compilation of all of the code.) Changed Files: U trunk/src/kadmin/server/ovsec_kadmd.c From lxs at MIT.EDU Thu Aug 28 12:37:36 2008 From: lxs at MIT.EDU (lxs@MIT.EDU) Date: Thu, 28 Aug 2008 12:37:36 -0400 (EDT) Subject: svn rev #20700: trunk/src/kim/agent/mac/ resources/English.lproj/ Message-ID: <200808281637.MAA02007@drugstore.mit.edu> Commit By: lxs Log Message: ticket: 6055 Additional code for KerberosAgent. Checking in so Justin can work on it. Changed Files: U trunk/src/kim/agent/mac/Identities.h U trunk/src/kim/agent/mac/Identities.m U trunk/src/kim/agent/mac/resources/English.lproj/Authentication.xib U trunk/src/kim/agent/mac/resources/English.lproj/SelectIdentity.xib From raeburn at MIT.EDU Thu Aug 28 13:17:52 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Thu, 28 Aug 2008 13:17:52 -0400 (EDT) Subject: svn rev #20701: trunk/src/kdc/ Message-ID: <200808281717.NAA02539@drugstore.mit.edu> Commit By: raeburn Log Message: Fix resource leak. Changed Files: U trunk/src/kdc/kdc_authdata.c From raeburn at MIT.EDU Thu Aug 28 14:11:51 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Thu, 28 Aug 2008 14:11:51 -0400 (EDT) Subject: svn rev #20702: trunk/src/lib/kadm5/srv/ Message-ID: <200808281811.OAA03324@drugstore.mit.edu> Commit By: raeburn Log Message: ticket: new subject: fix resource leak in USE_PASSWORD_SERVER code Don't leak file descriptors in error cases. Remove limit from length of passwords. Changed Files: U trunk/src/lib/kadm5/srv/svr_principal.c From raeburn at MIT.EDU Fri Aug 29 13:42:22 2008 From: raeburn at MIT.EDU (raeburn@MIT.EDU) Date: Fri, 29 Aug 2008 13:42:22 -0400 (EDT) Subject: svn rev #20703: trunk/src/include/ Message-ID: <200808291742.NAA17227@drugstore.mit.edu> Commit By: raeburn Log Message: Fix vasprintf signed/unsigned mix; separate out duplicated error paths; pull success return path out of guts of loop. Changed Files: U trunk/src/include/k5-platform.h