From jlrubin at mit.edu Fri Feb 7 21:08:44 2020 From: jlrubin at mit.edu (Jeremy) Date: Fri, 7 Feb 2020 18:08:44 -0800 Subject: [Bip-0119-review] CTV BIP & Code Review Message-ID: Hi Everyone, Over the next week or two I'm going to be sending out a small review task or two every day or every other day designed to get the CTV implementation and BIP more thoroughly vetted. Join the IRC channel ##ctv-bip-review for discussion. *BIP Task:* Let's start off easy: go ahead and read the BIP. Ask any questions you may have in IRC! I'll try to be responsive, but someone else can answer too! https://github.com/bitcoin/bips/blob/master/bip-0119.mediawiki *Code Review:* Our first review target for CTV is a simple refactoring (that taproot will also depend on!). https://github.com/bitcoin/bitcoin/pull/18071 This is just exposing some functionality we'll want down the line, and has no functional changes. It should take 5-10 minutes to review for correctness. But because it's just a few simple refactors, it can be merged today without controversy (I hope)! This will help make the eventual functional PR smaller. Once you've had a chance to look at it would love an ACK/utACK -- then we'll get into the meatier stuff next week! Best, Jeremy p.s. reminder to give workshop feedback if you haven't yet! https://docs.google.com/forms/d/e/1FAIpQLScZtury4DPJDkVIhYgcyGf6TlhDy_RPGP1JV9N36OPHcjGm7Q -- @JeremyRubin -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mailman.mit.edu/pipermail/bip-0119-review/attachments/20200207/f8bd30d3/attachment.html